Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-03 20:45:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

using map instead of eachSeries to load categories for /home. Error

Browse Source 
handling.
This commit is contained in:
Julian Lam
2013-10-12 10:37:44 -04:00
parent 4b89b3e2ed
commit 5d48ed5fb4
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/categories.js
View File

@@ -325,33 +325,40 @@ var RDB = require('./redis.js'),
return;
}
var categories = [];
// var categories = [];
function getCategory(cid, callback) {
Categories.getCategoryData(cid, function(err, categoryData) {
if (err) {
callback(err);
winston.warn('Attempted to retrieve cid ' + cid + ', but nothing was returned!');
callback(null, null);
return;
}
Categories.hasReadCategory(cid, current_user, function(hasRead) {
categoryData.badgeclass = (parseInt(categoryData.topic_count, 10) === 0 || (hasRead && current_user !== 0)) ? '' : 'badge-important';
categories.push(categoryData);
callback(null);
// categories.push(categoryData);
callback(null, categoryData);
});
});
}
async.eachSeries(cids, getCategory, function(err) {
async.map(cids, getCategory, function(err, categories) {
if (err) {
winston.err(err);
callback(null);
return;
}
categories = categories.sort(function(a, b) { return parseInt(a.order, 10) - parseInt(b.order, 10); });
categories = categories.filter(function(category) {
// Remove categories that have errored out
if (category) return true;
else return false;
}).sort(function(a, b) {
// Sort categories into their defined order
return parseInt(a.order, 10) - parseInt(b.order, 10);
});
callback({
'categories': categories