Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 00:56:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #9389, allow admins to add themselves to private groups

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-03-14 15:20:14 -04:00
parent 482641e30e
commit 5c59354c58
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/api/groups.js
View File

@@ -98,7 +98,7 @@ groupsAPI.join = async function (caller, data) {
return; return;
} }
if (isSelf && groupData.private && groupData.disableJoinRequests) { if (!isCallerAdmin && isSelf && groupData.private && groupData.disableJoinRequests) {
throw new Error('[[error:group-join-disabled]]'); throw new Error('[[error:group-join-disabled]]');
} }

6
test/groups.js
View File

@@ -723,6 +723,12 @@ describe('Groups', () => {
} }
meta.config.allowPrivateGroups = oldValue; meta.config.allowPrivateGroups = oldValue;
}); });
it('should allow admins to join private groups', async () => {
const groupsAPI = require('../src/api/groups');
await groupsAPI.join({ uid: adminUid }, { uid: adminUid, slug: 'global-moderators' });
assert(await Groups.isMember(adminUid, 'Global Moderators'));
});
}); });
describe('.leave()', () => { describe('.leave()', () => {