Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 00:56:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(acp): small UI fixes for ACP privileges category selector (#6946)

Browse Source 
- Add dropdown chevron
- Change translations
- Safety against `category` not an object
This commit is contained in:
Peter Jaszkowiak
2018-11-13 10:26:50 -07:00
committed by Julian Lam
parent c5a093e1f2
commit 57b39d5ba2
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
public/language/en-GB/admin/manage/categories.json
View File

@@ -29,7 +29,8 @@
"select-category": "Select Category", "select-category": "Select Category",
"set-parent-category": "Set Parent Category", "set-parent-category": "Set Parent Category",
"privileges.description": "You can configure the access control privileges for this category in this section. Privileges can be granted on a per-user or a per-group basis. You can add a new user to this table by searching for them in the form below.", "privileges.description": "You can configure the access control privileges for this category in this section. Privileges can be granted on a per-user or a per-group basis. Select the domain of effect from the dropdown below.",
"privileges.category-selector": "Configuring privileges for ",
"privileges.warning": "<strong>Note</strong>: Privilege settings take effect immediately. It is not necessary to save the category after adjusting these settings.", "privileges.warning": "<strong>Note</strong>: Privilege settings take effect immediately. It is not necessary to save the category after adjusting these settings.",
"privileges.section-viewing": "Viewing Privileges", "privileges.section-viewing": "Viewing Privileges",
"privileges.section-posting": "Posting Privileges", "privileges.section-posting": "Posting Privileges",

6
src/controllers/admin/privileges.js
View File

@@ -39,10 +39,10 @@ privilegesController.get = function (req, res, callback) {
data.allCategories.forEach(function (category) { data.allCategories.forEach(function (category) {
if (category) { if (category) {
category.selected = category.cid === cid; category.selected = category.cid === cid;
}
if (category.selected) { if (category.selected) {
data.selected = category; data.selected = category;
}
} }
}); });

4
src/views/admin/manage/privileges.tpl
View File

@@ -6,9 +6,9 @@
</p> </p>
<p class="lead"> <p class="lead">
Currently viewing privileges for [[admin/manage/categories:privileges.category-selector]]
<button type="button" id="category-selector" class="mdl-button mdl-js-button mdl-button--raised mdl-button--colored"> <button type="button" id="category-selector" class="mdl-button mdl-js-button mdl-button--raised mdl-button--colored">
{selected} {selected} <i class="fa fa-angle-down"></i>
</button> </button>
<ul class="mdl-menu mdl-menu--bottom-left mdl-js-menu mdl-js-ripple-effect" for="category-selector"> <ul class="mdl-menu mdl-menu--bottom-left mdl-js-menu mdl-js-ripple-effect" for="category-selector">