From 52e71522069fc08ad3becacf1d53e58726ce5e9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Thu, 11 Apr 2024 13:24:50 -0400 Subject: [PATCH] refactor: move parseInt to filter --- src/flags.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/flags.js b/src/flags.js index 833bb7edd8..e3932f3bd8 100644 --- a/src/flags.js +++ b/src/flags.js @@ -795,12 +795,10 @@ Flags.resolveUserPostFlags = async function (uid, callerUid) { if (meta.config['flags:autoResolveOnBan']) { await batch.processSortedSet(`uid:${uid}:posts`, async (pids) => { let postData = await posts.getPostsFields(pids, ['pid', 'flagId']); - postData = postData.filter(p => p && p.flagId); + postData = postData.filter(p => p && p.flagId && parseInt(p.flagId, 10)); for (const postObj of postData) { - if (parseInt(postObj.flagId, 10)) { - // eslint-disable-next-line no-await-in-loop - await Flags.update(postObj.flagId, callerUid, { state: 'resolved' }); - } + // eslint-disable-next-line no-await-in-loop + await Flags.update(postObj.flagId, callerUid, { state: 'resolved' }); } }, { batch: 500,