Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-11 16:35:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

added csrf to ajax calls

Browse Source
This commit is contained in:
Baris Usakli
2013-06-20 16:29:44 -04:00
parent a32103efbe
commit 523b787e69
8 changed files with 31 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
public/src/forum/account.js
View File

@@ -26,7 +26,8 @@
}
followBtn.on('click', function() {
$.post('/users/follow', {uid: theirid},
$.post('/users/follow', {uid: theirid, _csrf:$('#csrf_token').val()},
function(data) {
followBtn.remove();
$('#user-action-alert').html('You are now following'+ $('.account-username').text() +'!').show();

4
public/src/forum/accountedit.js
View File

@@ -80,7 +80,8 @@ $(document).ready(function() {
function changeUserPicture(type) {
var userData = {
uid: $('#inputUID').val(),
type: type
type: type,
_csrf:$('#csrf_token').val()
};
$.post('/users/changepicture',
@@ -103,6 +104,7 @@ $(document).ready(function() {
birthday:$('#inputBirthday').val(),
location:$('#inputLocation').val(),
signature:$('#inputSignature').val(),
_csrf:$('#csrf_token').val()
};
$.post('/users/doedit',

2
public/src/forum/following.js
View File

@@ -21,7 +21,7 @@
var removeBtn = $(this);
var followingUid = $(this).attr('followingUid');
$.post('/users/unfollow', {uid: followingUid},
$.post('/users/unfollow', {uid: followingUid, _csrf:$('#csrf_token').val()},
function(data) {
removeBtn.parent().remove();
}

6
public/templates/admin/users.tpl
View File

@@ -92,7 +92,8 @@
var uid = parent.attr('data-uid');
var userData = {
uid:uid
uid:uid,
_csrf:$('#csrf_token').val()
};
$.post('/admin/makeadmin',
@@ -122,7 +123,8 @@
var uid = parent.attr('data-uid');
var userData = {
uid:uid
uid:uid,
_csrf:$('#csrf_token').val()
};
$.post('/admin/removeadmin',

3
public/templates/header.tpl
View File

@@ -98,4 +98,7 @@
<div id="alert_window"></div>
<input id="csrf_token" type="hidden" template-variable="csrf" value="{csrf}" />
<div class="container" id="content">

6
src/routes/authentication.js
View File

@@ -86,7 +86,7 @@
console.log('info: [Auth] Session ' + req.sessionID + ' logout (uid: ' + global.uid + ')');
user_module.logout(req.sessionID, function(logout) {
req.logout();
res.send(app.build_header() + templates['logout'] + templates['footer']);
res.send(app.build_header(res) + templates['logout'] + templates['footer']);
});
});
@@ -120,11 +120,11 @@
app.get('/reset/:code', function(req, res) {
res.send(app.build_header() + templates['reset_code'].parse({ reset_code: req.params.code }) + templates['footer']);
res.send(app.build_header(res) + templates['reset_code'].parse({ reset_code: req.params.code }) + templates['footer']);
});
app.get('/reset', function(req, res) {
res.send(app.build_header() + templates['reset'] + templates['footer']);
res.send(app.build_header(res) + templates['reset'] + templates['footer']);
});

13
src/routes/user.js
View File

@@ -23,9 +23,8 @@ var user = require('./../user.js'),
});
app.get('/users', function(req, res) {
console.log('derp');
user.getUserList(function(data) {
res.send(app.build_header() + app.create_route("users", "users") + templates['footer']);
res.send(app.build_header(res) + app.create_route("users", "users") + templates['footer']);
});
});
@@ -43,7 +42,7 @@ var user = require('./../user.js'),
user.getUserData(uid, function(data) {
if(data) {
res.send(app.build_header() + app.create_route('users/'+data.username, 'account') + templates['footer']);
res.send(app.build_header(res) + app.create_route('users/'+data.username, 'account') + templates['footer']);
}
else {
res.redirect('/404');
@@ -60,7 +59,7 @@ var user = require('./../user.js'),
user.getUserField(req.user.uid, 'username', function(username) {
if(req.params.username && username === req.params.username)
res.send(app.build_header() + app.create_route('users/'+req.params.username+'/edit','accountedit') + templates['footer']);
res.send(app.build_header(res) + app.create_route('users/'+req.params.username+'/edit','accountedit') + templates['footer']);
else
return res.redirect('/404');
});
@@ -223,7 +222,7 @@ var user = require('./../user.js'),
if(!req.user)
return res.redirect('/403');
res.send(app.build_header() + app.create_route('users/'+req.params.username+'/following','following') + templates['footer']);
res.send(app.build_header(res) + app.create_route('users/'+req.params.username+'/following','following') + templates['footer']);
});
app.get('/users/:username/followers', function(req, res) {
@@ -231,11 +230,11 @@ var user = require('./../user.js'),
if(!req.user)
return res.redirect('/403');
res.send(app.build_header() + app.create_route('users/'+req.params.username+'/followers','followers') + templates['footer']);
res.send(app.build_header(res) + app.create_route('users/'+req.params.username+'/followers','followers') + templates['footer']);
});
function api_method(req, res) {
console.log('derp');
var callerUID = req.user?req.user.uid : 0;
if (!req.params.section && !req.params.username) {

15
src/webserver.js
View File

@@ -23,10 +23,11 @@ var express = require('express'),
(function(app) {
var templates = null;
app.build_header = function() {
app.build_header = function(res) {
return templates['header'].parse({
cssSrc: global.config['theme:src'] || '/vendor/bootstrap/css/bootstrap.min.css',
title: global.config['title'] || 'NodeBB'
title: global.config['title'] || 'NodeBB',
csrf:res.locals.csrf_token
});
};
@@ -94,7 +95,7 @@ var express = require('express'),
return;
}
res.send(app.build_header() + app.create_route(route) + templates['footer']);
res.send(app.build_header(res) + app.create_route(route) + templates['footer']);
});
}(routes[i]));
}
@@ -104,7 +105,7 @@ var express = require('express'),
app.get('/', function(req, res) {
categories.getAllCategories(function(returnData) {
res.send(
app.build_header() +
app.build_header(res) +
'\n\t<noscript>\n' + templates['noscript/header'] + templates['noscript/home'].parse(returnData) + '\n\t</noscript>' +
app.create_route('') +
templates['footer']
@@ -132,7 +133,7 @@ var express = require('express'),
var topic_url = tid + (req.params.slug ? '/' + req.params.slug : '');
topics.getTopicById(tid, ((req.user) ? req.user.uid : 0), function(topic) {
res.send(
app.build_header() +
app.build_header(res) +
'\n\t<noscript>\n' + templates['noscript/header'] + templates['noscript/topic'].parse(topic) + '\n\t</noscript>' +
'\n\t<script>templates.ready(function(){ajaxify.go("topic/' + topic_url + '");});</script>' +
templates['footer']
@@ -160,7 +161,7 @@ var express = require('express'),
categories.getCategoryById(cid, 0, function(returnData) {
console.log(returnData);
res.send(
app.build_header() +
app.build_header(res) +
'\n\t<noscript>\n' + templates['noscript/header'] + templates['noscript/category'].parse(returnData) + '\n\t</noscript>' +
'\n\t<script>templates.ready(function(){ajaxify.go("category/' + category_url + '");});</script>' +
templates['footer']
@@ -169,7 +170,7 @@ var express = require('express'),
});
app.get('/confirm/:code', function(req, res) {
res.send(app.build_header() + '<script>templates.ready(function(){ajaxify.go("confirm/' + req.params.code + '");});</script>' + templates['footer']);
res.send(app.build_header(res) + '<script>templates.ready(function(){ajaxify.go("confirm/' + req.params.code + '");});</script>' + templates['footer']);
});
// These functions are called via ajax once the initial page is loaded to populate templates with data