Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-02 20:16:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

dont call groups.get just to read 2 values

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2015-05-26 13:44:52 -04:00
parent 3f1726636f
commit 50d9a3f0a7
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/groups.js
View File

@@ -647,13 +647,12 @@ var async = require('async'),
uid: uid
});
// If this is a hidden group, and it is now empty, delete it
Groups.get(groupName, {}, function(err, group) {
if (err || !group) {
Groups.getGroupFields(groupName, ['hidden', 'memberCount'], function(err, groupData) {
if (err || !groupData) {
return callback(err);
}
if (group.hidden && group.memberCount === 0) {
if (parseInt(groupData.hidden, 10) === 1 && parseInt(groupData.memberCount, 10) === 0) {
Groups.destroy(groupName, callback);
} else {
callback();