Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-01 21:30:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #7576 "Disable password changes" can be sidestepped

Browse Source
This commit is contained in:
Andrew Rodrigues
2019-05-09 15:51:36 -04:00
parent e114b16d7a
commit 50260e137a
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/controllers/index.js
View File

@@ -40,6 +40,10 @@ Controllers.errors = require('./errors');
Controllers.composer = require('./composer');
Controllers.reset = function (req, res, next) {
if (meta.config['password:disableEdit']) {
return helpers.notAllowed(req, res);
}
res.locals.metaTags = {
...res.locals.metaTags,
name: 'robots',
@@ -120,6 +124,7 @@ Controllers.login = function (req, res, next) {
}]);
data.error = req.flash('error')[0] || errorText;
data.title = '[[pages:login]]';
data.allowPasswordReset = !meta.config['password:disableEdit'];
privileges.global.canGroup('local:login', 'registered-users', function (err, hasLoginPrivilege) {
if (err) {

4
src/socket.io/user.js
View File

@@ -100,6 +100,10 @@ SocketUser.reset.send = function (socket, email, callback) {
return callback(new Error('[[error:invalid-data]]'));
}
if (meta.config['password:disableEdit']) {
return callback(new Error('[[error:no-privileges]]'));
}
user.reset.send(email, function (err) {
events.log({
type: 'password-reset',