From 4fb907875e31501a28427c7ec1e41b4862649e35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <baris@nodebb.org>
Date: Sun, 17 Jan 2021 13:10:28 -0500
Subject: [PATCH] fix: don't crash if fullname is not a string

https://community.nodebb.org/topic/15291/upgrade-error-fullname-substr-is-not-a-function
---
 src/upgrades/1.15.0/fullname_search_set.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/upgrades/1.15.0/fullname_search_set.js b/src/upgrades/1.15.0/fullname_search_set.js
index 9f479af145..c3955226bd 100644
--- a/src/upgrades/1.15.0/fullname_search_set.js
+++ b/src/upgrades/1.15.0/fullname_search_set.js
@@ -16,7 +16,7 @@ module.exports = {
 			const userData = await user.getUsersFields(uids, ['uid', 'fullname']);
 			const bulkAdd = userData
 				.filter(u => u.uid && u.fullname)
-				.map(u => ['fullname:sorted', 0, u.fullname.substr(0, 255).toLowerCase() + ':' + u.uid]);
+				.map(u => ['fullname:sorted', 0, String(u.fullname).substr(0, 255).toLowerCase() + ':' + u.uid]);
 			await db.sortedSetAddBulk(bulkAdd);
 		}, {
 			batch: 500,