Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-02 20:16:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

optimize topics.markTopicNotificationsRead

Browse Source 
let's not call it once for each tid
This commit is contained in:
barisusakli
2016-09-19 23:43:50 +03:00
parent 877820779c
commit 4ce8e2224a
5 changed files with 25 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/topics/unread.js
View File

@@ -279,9 +279,7 @@ module.exports = function(Topics) {
db.getSortedSetRevRangeByScore('topics:recent', 0, -1, '+inf', Topics.unreadCutoff(), next);
},
function (tids, next) {
for (var i=0; i<tids.length; ++i) {
Topics.markTopicNotificationsRead(tids[i], uid);
}
Topics.markTopicNotificationsRead(tids, uid);
Topics.markAsRead(tids, uid, next);
},
function (markedRead, next) {
@@ -290,17 +288,23 @@ module.exports = function(Topics) {
], callback);
};
Topics.markTopicNotificationsRead = function(tid, uid) {
if (!tid) {
Topics.markTopicNotificationsRead = function(tids, uid) {
if (!Array.isArray(tids) || !tids.length) {
return;
}
user.notifications.getUnreadByField(uid, 'tid', tid, function(err, nids) {
if (err) {
return winston.error(err.stack);
async.waterfall([
function(next) {
user.notifications.getUnreadByField(uid, 'tid', tids, next);
},
function(nids, next) {
notifications.markReadMultiple(nids, uid, next);
}
notifications.markReadMultiple(nids, uid, function() {
user.notifications.pushCount(uid);
});
], function(err) {
if (err) {
return winston.error(err);
}
user.notifications.pushCount(uid);
});
};