Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-07 22:45:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

disable stuff that crashes in socket.io 1.x

Browse Source
This commit is contained in:
barisusakli
2014-11-25 15:18:33 -05:00
parent 396dffd60f
commit 4bed05a622
3 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/logger.js
View File

@@ -159,7 +159,7 @@ var opts = {
/*
* Restore all hijacked sockets to their original emit/on functions
*/
var clients = socket.io.sockets.clients();
var clients = []; //socket.io.sockets.clients(); doesn't work in socket.io 1.x
clients.forEach(function(client) {
if(client.oEmit && client.oEmit !== client.emit) {
client.emit = client.oEmit;
@@ -179,7 +179,7 @@ var opts = {
return;
}
var clients = socket.io.sockets.clients();
var clients = []; //socket.io.sockets.clients(); doesn't work in socket.io 1.x
clients.forEach(function(client) {
Logger.io_one(client, client.uid);

2
src/socket.io/index.js
View File

@@ -285,7 +285,7 @@ Sockets.uidInRoom = function(uid, room) {
};
Sockets.getSocketCount = function() {
return false;
return 0;
var clients = io.sockets.manager.rooms[''];
return Array.isArray(clients) ? clients.length : 0;

5
src/socket.io/meta.js
View File

@@ -86,8 +86,9 @@ SocketMeta.rooms.enter = function(socket, data, callback) {
};
SocketMeta.rooms.getAll = function(socket, data, callback) {
var rooms = websockets.server.sockets.manager.rooms,
socketData = {
var rooms = {}; //websockets.server.sockets.manager.rooms; doesnt work in socket.io 1.x
var socketData = {
onlineGuestCount: websockets.getOnlineAnonCount(),
onlineRegisteredCount: websockets.getOnlineUserCount(),
socketCount: websockets.getSocketCount(),