Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 11:05:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: context actor to serve an as:OrderedCollection instead of as:Page, and added context property (as per FEP-7888) to refer to it, changed audience to point to category

Browse Source
This commit is contained in:
Julian Lam
2024-05-03 14:11:17 -04:00
parent 32d1adf67d
commit 4b29a1b91d
2 changed files with 43 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/activitypub/mocks.js
View File

@@ -326,7 +326,8 @@ Mocks.note = async (post) => {
published,
url: id,
attributedTo: `${nconf.get('url')}/uid/${post.user.uid}`,
audience: `${nconf.get('url')}/topic/${post.topic.slug}`,
context: `${nconf.get('url')}/topic/${post.topic.tid}`,
audience: `${nconf.get('url')}/category/${post.category.cid}`,
sensitive: false, // todo
summary: null,
name,

52
src/controllers/activitypub/actors.js
View File

@@ -62,22 +62,52 @@ Actors.note = async function (req, res) {
res.status(200).json(payload);
};
Actors.topic = async function (req, res) {
// When queried, a topic more or less returns the main pid's note representation
Actors.topic = async function (req, res, next) {
const allowed = await privileges.topics.can('topics:read', req.params.tid, activitypub._constants.uid);
const { mainPid, slug } = await topics.getTopicFields(req.params.tid, ['mainPid', 'slug']);
const post = (await posts.getPostSummaryByPids([mainPid], req.uid, { stripTags: false })).pop();
if (!allowed || !post) {
if (!allowed) {
return res.sendStatus(404);
}
const payload = await activitypub.mocks.note(post);
payload.id = `${nconf.get('url')}/topic/${req.params.tid}`;
payload.type = 'Page';
payload.url = `${nconf.get('url')}/topic/${slug}`;
payload.audience = `${nconf.get('url')}/category/${post.category.slug}`;
const page = parseInt(req.query.page, 10);
const { cid, mainPid, slug, postcount } = await topics.getTopicFields(req.params.tid, ['cid', 'mainPid', 'slug', 'postcount']);
const pageCount = Math.max(1, Math.ceil(postcount / meta.config.postsPerPage));
let items;
res.status(200).json(payload);
if (page) {
const invalidPagination = page < 1 || page > pageCount;
if (invalidPagination) {
return next();
}
const start = Math.max(0, ((page - 1) * meta.config.postsPerPage) - 1);
const stop = Math.max(0, start + meta.config.postsPerPage - 1);
const pids = await posts.getPidsFromSet(`tid:${req.params.tid}:posts`, start, stop);
if (page === 1) {
pids.unshift(mainPid);
pids.length = Math.min(pids.length, meta.config.postsPerPage);
}
items = pids.map(pid => (utils.isNumber(pid) ? `${nconf.get('url')}/post/${pid}` : pid));
}
const object = {
'@context': 'https://www.w3.org/ns/activitystreams',
id: `${nconf.get('url')}/topic/${req.params.tid}${page ? `?page=${page}` : ''}`,
url: `${nconf.get('url')}/topic/${slug}`,
type: items ? 'OrderedCollectionPage' : 'OrderedCollection',
audience: `${nconf.get('url')}/category/${cid}`,
totalItems: postcount,
};
if (items) {
object.partOf = `${nconf.get('url')}/topic/${req.params.tid}`;
object.items = items;
object.next = page < pageCount ? `${nconf.get('url')}/topic/${req.params.tid}?page=${page + 1}` : null;
object.prev = page > 1 ? `${nconf.get('url')}/topic/${req.params.tid}?page=${page - 1}` : null;
}
object.first = `${nconf.get('url')}/topic/${req.params.tid}?page=1`;
object.last = `${nconf.get('url')}/topic/${req.params.tid}?page=${pageCount}`;
res.status(200).json(object);
};
Actors.category = async function (req, res, next) {