Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: email update interstitial to not error on empty email field (on new registration)

Browse Source
This commit is contained in:
Julian Lam
2021-07-30 15:08:43 -04:00
parent 70a04bc105
commit 4a521ea218
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/controllers/authentication.js
View File

@@ -23,7 +23,7 @@ const sockets = require('../socket.io');
const authenticationController = module.exports; const authenticationController = module.exports;
async function registerAndLoginUser(req, res, userData) { async function registerAndLoginUser(req, res, userData) {
if (!userData.email) { if (!userData.hasOwnProperty('email')) {
userData.updateEmail = true; userData.updateEmail = true;
} }
@@ -198,8 +198,10 @@ authenticationController.registerComplete = function (req, res, next) {
const data = await registerAndLoginUser(req, res, req.session.registration); const data = await registerAndLoginUser(req, res, req.session.registration);
if (!data) { if (!data) {
winston.warn('[register] Interstitial callbacks processed with no errors, but one or more interstitials remain. This is likely an issue with one of the interstitials not properly handling a null case or invalid value.'); return winston.warn('[register] Interstitial callbacks processed with no errors, but one or more interstitials remain. This is likely an issue with one of the interstitials not properly handling a null case or invalid value.');
} }
done();
} else { } else {
// Update user hash, clear registration data in session // Update user hash, clear registration data in session
const payload = req.session.registration; const payload = req.session.registration;