Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-30 18:46:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: admin groups.join socket async/await

Browse Source
This commit is contained in:
Julian Lam
2019-09-05 11:20:01 -04:00
parent 7c0cfc33ea
commit 4588a4fdcf
1 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/socket.io/admin/groups.js
View File

@@ -19,22 +19,17 @@ Groups.create = function (socket, data, callback) {
}, callback);
};
Groups.join = function (socket, data, callback) {
Groups.join = async (socket, data) => {
if (!data) {
return callback(new Error('[[error:invalid-data]]'));
throw new Error('[[error:invalid-data]]');
}
async.waterfall([
function (next) {
groups.isMember(data.uid, data.groupName, next);
},
function (isMember, next) {
if (isMember) {
return next(new Error('[[error:group-already-member]]'));
}
groups.join(data.groupName, data.uid, next);
},
], callback);
const isMember = await groups.isMember(data.uid, data.groupName);
if (isMember) {
throw new Error('[[error:group-already-member]]');
}
return await groups.join(data.groupName, data.uid);
};
Groups.leave = function (socket, data, callback) {