Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-17 03:01:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: switch inf. scroll to xhr (#9854)

Browse Source 
this fixes infinitescroll when url has custom query parameters
also fixes infinitescroll for plugins like QnA
fixes infinitescroll on tags page
deprecate topics.loadMoreSortedTopics
deprecate topics.loadMoreFromSet
This commit is contained in:
Barış Soner Uşaklı
2021-10-02 13:35:58 -04:00
committed by GitHub
parent cb25faaa2d
commit 4404e81991
3 changed files with 12 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/socket.io/topics/infinitescroll.js
View File

@@ -1,5 +1,7 @@
'use strict';
const winston = require('winston');
const topics = require('../../topics');
const privileges = require('../../privileges');
const meta = require('../../meta');
@@ -62,6 +64,7 @@ module.exports = function (SocketTopics) {
};
SocketTopics.loadMoreSortedTopics = async function (socket, data) {
winston.warn('[deprecated] use infinitescroll.loadMoreXhr'); // TODO: remove in 1.19.0
if (!data || !utils.isNumber(data.after) || parseInt(data.after, 10) < 0) {
throw new Error('[[error:invalid-data]]');
}
@@ -85,6 +88,7 @@ module.exports = function (SocketTopics) {
};
SocketTopics.loadMoreFromSet = async function (socket, data) {
winston.warn('[deprecated] use infinitescroll.loadMoreXhr'); // TODO: remove in 1.19.0
if (!data || !utils.isNumber(data.after) || parseInt(data.after, 10) < 0 || !data.set) {
throw new Error('[[error:invalid-data]]');
}