Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 11:35:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: allow optional fields argument on db.getObject(s) (#9385)

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-03-14 11:40:54 -04:00
committed by GitHub
parent 754965b572
commit 4327a09d76
9 changed files with 53 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
test/database/hash.js
View File

@@ -161,6 +161,12 @@ describe('Hash methods', () => {
done();
});
});
it('should return fields if given', async () => {
const data = await db.getObject('hashTestObject', ['name', 'age']);
assert.strictEqual(data.name, 'baris');
assert.strictEqual(parseInt(data.age, 10), 99);
});
});
describe('getObjects()', () => {
@@ -182,6 +188,18 @@ describe('Hash methods', () => {
done();
});
});
it('should return fields if given', async () => {
await db.setObject('fieldsObj1', { foo: 'foo', baz: 'baz', herp: 'herp' });
await db.setObject('fieldsObj2', { foo: 'foo2', baz: 'baz2', herp: 'herp2', onlyin2: 'onlyin2' });
const data = await db.getObjects(['fieldsObj1', 'fieldsObj2'], ['baz', 'doesnotexist', 'onlyin2']);
assert.strictEqual(data[0].baz, 'baz');
assert.strictEqual(data[0].doesnotexist, null);
assert.strictEqual(data[0].onlyin2, null);
assert.strictEqual(data[1].baz, 'baz2');
assert.strictEqual(data[1].doesnotexist, null);
assert.strictEqual(data[1].onlyin2, 'onlyin2');
});
});
describe('getObjectField()', () => {
@@ -295,6 +313,17 @@ describe('Hash methods', () => {
done();
});
});
it('should return all fields if fields is empty array', async () => {
const objects = await db.getObjectsFields(['testObject8', 'testObject9', 'doesnotexist'], []);
assert(Array.isArray(objects));
assert.strict(objects.length, 3);
assert.strictEqual(objects[0].name, 'baris');
assert.strictEqual(Number(objects[0].age), 99);
assert.strictEqual(objects[1].name, 'ginger');
assert.strictEqual(Number(objects[1].age), 3);
assert.strictEqual(!!objects[2], false);
});
});
describe('getObjectKeys()', () => {