Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 03:26:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: tests for topic thumbs

Browse Source 
Also added some error checking to addThumbs controller
This commit is contained in:
Julian Lam
2020-12-04 11:47:22 -05:00
parent ef7d6db912
commit 4152aa552e
3 changed files with 197 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/controllers/write/topics.js
View File

@@ -94,27 +94,20 @@ Topics.getThumbs = async (req, res) => {
helpers.formatApiResponse(200, res, await topics.thumbs.get(req.params.tid));
};
Topics.addThumb = async (req, res) => {
Topics.addThumb = async (req, res, next) => {
await checkThumbPrivileges({ tid: req.params.tid, uid: req.user.uid, res });
if (res.headersSent) {
return;
}
/**
* todo test:
* - uuid
* - tid
* - number but not tid
* - random garbage
* - wrong caller uid (unpriv)
*/
const files = await uploadsController.uploadThumb(req, res); // response is handled here, fix this?
const files = await uploadsController.uploadThumb(req, res, next); // response is handled here, fix this?
// Add uploaded files to topic zset
await Promise.all(files.map(async (fileObj) => {
await topics.thumbs.associate(req.params.tid, fileObj.path);
}));
if (files && files.length) {
await Promise.all(files.map(async (fileObj) => {
await topics.thumbs.associate(req.params.tid, fileObj.path);
}));
}
};
Topics.migrateThumbs = async (req, res) => {