Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-06 05:55:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

added new hook to allow plugins to override the local login strategy with their own, closes #2806

Browse Source
This commit is contained in:
Julian Lam
2015-02-27 10:55:10 -05:00
parent 01b012d89d
commit 3ef54c3c01
1 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/routes/authentication.js
View File

@@ -38,6 +38,13 @@
plugins.ready(function() { plugins.ready(function() {
loginStrategies.length = 0; loginStrategies.length = 0;
if (plugins.hasListeners('action:auth.overrideLogin')) {
winston.warn('[authentication] Login override detected, skipping local login strategy.');
plugins.fireHook('action:auth.overrideLogin');
} else {
passport.use(new passportLocal({passReqToCallback: true}, Auth.login));
}
plugins.fireHook('filter:auth.init', loginStrategies, function(err) { plugins.fireHook('filter:auth.init', loginStrategies, function(err) {
if (err) { if (err) {
winston.error('filter:auth.init - plugin failure'); winston.error('filter:auth.init - plugin failure');
@@ -110,8 +117,6 @@
], next); ], next);
}; };
passport.use(new passportLocal({passReqToCallback: true}, Auth.login));
passport.serializeUser(function(user, done) { passport.serializeUser(function(user, done) {
done(null, user.uid); done(null, user.uid);
}); });
@@ -132,6 +137,10 @@
req.session.returnTo = req.body.returnTo; req.session.returnTo = req.body.returnTo;
} }
if (plugins.hasListeners('action:auth.overrideLogin')) {
return Auth.continueLogin(req, res, next);
};
var loginWith = meta.config.allowLoginWith || 'username-email'; var loginWith = meta.config.allowLoginWith || 'username-email';
if (req.body.username && utils.isEmailValid(req.body.username) && loginWith.indexOf('email') !== -1) { if (req.body.username && utils.isEmailValid(req.body.username) && loginWith.indexOf('email') !== -1) {
@@ -140,16 +149,16 @@
return next(err); return next(err);
} }
req.body.username = username ? username : req.body.username; req.body.username = username ? username : req.body.username;
continueLogin(req, res, next); Auth.continueLogin(req, res, next);
}); });
} else if (loginWith.indexOf('username') !== -1 && !validator.isEmail(req.body.username)) { } else if (loginWith.indexOf('username') !== -1 && !validator.isEmail(req.body.username)) {
continueLogin(req, res, next); Auth.continueLogin(req, res, next);
} else { } else {
res.status(500).send('[[error:wrong-login-type-' + loginWith + ']]'); res.status(500).send('[[error:wrong-login-type-' + loginWith + ']]');
} }
} }
function continueLogin(req, res, next) { Auth.continueLogin = function(req, res, next) {
passport.authenticate('local', function(err, userData, info) { passport.authenticate('local', function(err, userData, info) {
if (err) { if (err) {
return res.status(403).send(err.message); return res.status(403).send(err.message);
@@ -196,7 +205,7 @@
} }
}); });
})(req, res, next); })(req, res, next);
} };
function register(req, res) { function register(req, res) {
if (parseInt(meta.config.allowRegistration, 10) === 0) { if (parseInt(meta.config.allowRegistration, 10) === 0) {