Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 19:15:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #9092, Topic thumbnails do not work with third-party uploaders

Browse Source
This commit is contained in:
Julian Lam
2020-12-09 15:47:58 -05:00
parent dd448e2b1a
commit 3e54b70c06
4 changed files with 92 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/controllers/write/topics.js
View File

@@ -7,6 +7,7 @@ const topics = require('../../topics');
const privileges = require('../../privileges');
const helpers = require('../helpers');
const middleware = require('../../middleware/assert');
const uploadsController = require('../uploads');
const Topics = module.exports;
@@ -105,7 +106,11 @@ Topics.addThumb = async (req, res) => {
// Add uploaded files to topic zset
if (files && files.length) {
await Promise.all(files.map(async (fileObj) => {
await topics.thumbs.associate(req.params.tid, fileObj.path);
await topics.thumbs.associate({
id: req.params.tid,
path: fileObj.path || null,
url: fileObj.url,
});
}));
}
};
@@ -124,6 +129,13 @@ Topics.migrateThumbs = async (req, res) => {
};
Topics.deleteThumb = async (req, res) => {
if (!req.body.path.startsWith('http')) {
await middleware.assert.path(req, res);
if (res.headersSent) {
return;
}
}
await checkThumbPrivileges({ tid: req.params.tid, uid: req.user.uid, res });
if (res.headersSent) {
return;