Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-29 18:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

removed command param made unvote wrapper

Browse Source
This commit is contained in:
barisusakli
2014-11-17 21:45:52 -05:00
parent 8c98f47688
commit 3d93a76508
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/favourites.js
View File

@@ -122,7 +122,7 @@ var async = require('async'),
}); });
} }
Favourites.upvote = function(pid, uid, commmand, callback) { Favourites.upvote = function(pid, uid, callback) {
if (parseInt(meta.config['reputation:disabled'], 10) === 1) { if (parseInt(meta.config['reputation:disabled'], 10) === 1) {
return callback(new Error('[[error:reputation-system-disabled]]')); return callback(new Error('[[error:reputation-system-disabled]]'));
} }
@@ -136,7 +136,7 @@ var async = require('async'),
}); });
}; };
Favourites.downvote = function(pid, uid, command, callback) { Favourites.downvote = function(pid, uid, callback) {
if (parseInt(meta.config['reputation:disabled'], 10) === 1) { if (parseInt(meta.config['reputation:disabled'], 10) === 1) {
return callback(new Error('[[error:reputation-system-disabled]]')); return callback(new Error('[[error:reputation-system-disabled]]'));
} }
@@ -158,14 +158,14 @@ var async = require('async'),
if (err) { if (err) {
return callback(err); return callback(err);
} }
callback(null, votes); callback(null, votes);
}); });
}); });
}; };
function toggleVote(type, pid, uid, callback) { function toggleVote(type, pid, uid, callback) {
Favourites.unvote(pid, uid, type, function(err) { unvote(pid, uid, type, function(err) {
if (err) { if (err) {
return callback(err); return callback(err);
} }
@@ -174,7 +174,11 @@ var async = require('async'),
}); });
} }
Favourites.unvote = function(pid, uid, command, callback) { Favourites.unvote = function(pid, uid, callback) {
unvote(pid, uid, 'unvote', callback);
};
function unvote(pid, uid, command, callback) {
Favourites.hasVoted(pid, uid, function(err, voteStatus) { Favourites.hasVoted(pid, uid, function(err, voteStatus) {
if (err) { if (err) {
return callback(err); return callback(err);
@@ -243,11 +247,11 @@ var async = require('async'),
}, callback); }, callback);
}; };
Favourites.favourite = function (pid, uid, command, callback) { Favourites.favourite = function (pid, uid, callback) {
toggleFavourite('favourite', pid, uid, callback); toggleFavourite('favourite', pid, uid, callback);
}; };
Favourites.unfavourite = function(pid, uid, command, callback) { Favourites.unfavourite = function(pid, uid, callback) {
toggleFavourite('unfavourite', pid, uid, callback); toggleFavourite('unfavourite', pid, uid, callback);
}; };

2
src/socket.io/posts.js
View File

@@ -115,7 +115,7 @@ function favouriteCommand(command, eventName, socket, data, callback) {
return callback(new Error('[[error:post-deleted]]')); return callback(new Error('[[error:post-deleted]]'));
} }
favourites[command](data.pid, socket.uid, command, function(err, result) { favourites[command](data.pid, socket.uid, function(err, result) {
if (err) { if (err) {
return callback(err); return callback(err);
} }