Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-16 10:46:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove chat message notification queue, implement merge IDs for chat message notifications, so they can be grouped together

Browse Source
This commit is contained in:
Julian Lam
2023-09-27 14:09:07 -04:00
parent a5c1b2a0bc
commit 3ba371f6c2
6 changed files with 30 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/notifications.js
View File

@@ -374,6 +374,7 @@ Notifications.merge = async function (notifications) {
'notifications:user_posted_to',
'notifications:user_flagged_post_in',
'notifications:user_flagged_user',
'new-chat',
'notifications:user_posted_in_public_room',
'new_register',
'post-queue',
@@ -417,6 +418,15 @@ Notifications.merge = async function (notifications) {
}
const notifObj = notifications[modifyIndex];
switch (mergeId) {
case 'new-chat': {
const { roomId, roomName, type, user } = set[0];
const isGroupChat = type === 'new-group-chat';
notifObj.bodyShort = isGroupChat || (roomName !== `[[modules:chat.room-id, ${roomId}]]`) ?
`[[notifications:new_messages_in, ${set.length}, ${roomName}]]` :
`[[notifications:new_messages_from, ${set.length}, ${user.displayname}]]`;
break;
}
case 'notifications:user_posted_in_public_room': {
const usernames = _.uniq(set.map(notifObj => notifObj && notifObj.user && notifObj.user.displayname));
if (usernames.length === 2 || usernames.length === 3) {