Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: no need to pass in empty Set in deprecated hooks

Browse Source
This commit is contained in:
Julian Lam
2022-06-15 13:37:54 -04:00
parent c7fa73b163
commit 3a015eb8e3
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/hooks.js
View File

@@ -12,25 +12,21 @@ Hooks._deprecated = new Map([
new: 'static:email.send',
since: 'v1.17.0',
until: 'v2.0.0',
affected: new Set(),
}],
['filter:router.page', {
new: 'response:router.page',
since: 'v1.15.3',
until: 'v2.1.0',
affected: new Set(),
}],
['filter:post.purge', {
new: 'filter:posts.purge',
since: 'v1.19.6',
until: 'v2.1.0',
affected: new Set(),
}],
['action:post.purge', {
new: 'action:posts.purge',
since: 'v1.19.6',
until: 'v2.1.0',
affected: new Set(),
}],
]);
@@ -63,6 +59,9 @@ Hooks.register = function (id, data) {
// `hasOwnProperty` needed for hooks with no alternative (set to null)
if (Hooks._deprecated.has(data.hook)) {
const deprecation = Hooks._deprecated.get(data.hook);
if (!deprecation.hasOwnProperty('affected')) {
deprecation.affected = new Set();
}
deprecation.affected.add(id);
Hooks._deprecated.set(data.hook, deprecation);
}