diff --git a/src/user/create.js b/src/user/create.js index f1ad7f9294..a9d22ac3c6 100644 --- a/src/user/create.js +++ b/src/user/create.js @@ -90,6 +90,9 @@ module.exports = function(User) { }, function(next) { async.parallel([ + function(next) { + db.incrObjectField('global', 'userCount', next); + }, function(next) { db.sortedSetAdd('username:uid', userData.uid, userData.username, next); }, @@ -141,9 +144,6 @@ module.exports = function(User) { ], next); }, function(results, next) { - db.incrObjectField('global', 'userCount', next); - }, - function(next) { if (userNameChanged) { User.notifications.sendNameChangeNotification(userData.uid, userData.username); } @@ -155,15 +155,6 @@ module.exports = function(User) { }); }; - User.updateUserCount = function(callback) { - db.sortedSetCard('users:joindate', function(err, count) { - if (err) { - return callback(err); - } - db.setObjectField('global', 'userCount', count, callback); - }); - }; - function isDataValid(userData, callback) { async.parallel({ emailValid: function(next) { diff --git a/src/user/delete.js b/src/user/delete.js index 2558399134..f27527e1e4 100644 --- a/src/user/delete.js +++ b/src/user/delete.js @@ -79,6 +79,9 @@ module.exports = function(User) { 'users:online' ], uid, next); }, + function(next) { + db.decrObjectField('global', 'userCount', next); + }, function(next) { var keys = [ 'uid:' + uid + ':notifications:read', 'uid:' + uid + ':notifications:unread', @@ -107,14 +110,7 @@ module.exports = function(User) { return callback(err); } - async.parallel([ - function(next) { - db.deleteAll(['followers:' + uid, 'following:' + uid, 'user:' + uid], next); - }, - function(next) { - User.updateUserCount(next); - } - ], callback); + db.deleteAll(['followers:' + uid, 'following:' + uid, 'user:' + uid], callback); }); }); };