Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #8418

Browse Source 
allow updating other profile fields when username isnt being changed
This commit is contained in:
Barış Soner Uşaklı
2020-09-12 21:48:56 -04:00
parent 4be693f2e7
commit 38d3982bf1
2 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/user/profile.js
View File

@@ -86,7 +86,9 @@ module.exports = function (User) {
}
data.username = data.username.trim();
const userData = await User.getUserFields(uid, ['username', 'userslug']);
var userslug = utils.slugify(data.username);
if (userData.username === data.username) {
return;
}
if (data.username.length < meta.config.minimumUsernameLength) {
throw new Error('[[error:username-too-short]]');
@@ -96,6 +98,7 @@ module.exports = function (User) {
throw new Error('[[error:username-too-long]]');
}
const userslug = utils.slugify(data.username);
if (!utils.isUserNameValid(data.username) || !userslug) {
throw new Error('[[error:invalid-username]]');
}

16
test/user.js
View File

@@ -900,6 +900,22 @@ describe('User', function () {
});
});
it('should not let setting an empty username', async function () {
await socketUser.changeUsernameEmail({ uid: uid }, { uid: uid, username: '', password: '123456' });
const username = await db.getObjectField('user:' + uid, 'username');
assert.strictEqual(username, 'updatedAgain');
});
it('should let updating profile if current username is above max length and it is not being changed', async function () {
const maxLength = meta.config.maximumUsernameLength + 1;
const longName = new Array(maxLength).fill('a').join('');
const uid = await User.create({ username: longName });
await socketUser.changeUsernameEmail({ uid: uid }, { uid: uid, username: longName, email: 'verylong@name.com' });
const userData = await db.getObject('user:' + uid);
assert.strictEqual(userData.username, longName);
assert.strictEqual(userData.email, 'verylong@name.com');
});
it('should not update a user\'s username if it did not change', function (done) {
socketUser.changeUsernameEmail({ uid: uid }, { uid: uid, username: 'updatedAgain', password: '123456' }, function (err) {
assert.ifError(err);