Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-02 12:05:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: deprecated-message not showing for all hooks (#4714)

Browse Source 
* fix deprecated hooks params warning + var-cleanup

* fix deprecated message
This commit is contained in:
Aziz Khoury
2016-06-01 12:27:36 -04:00
committed by Julian Lam
parent 5baf077cbe
commit 374fa8dd8c
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/hooks.js
View File

@@ -57,14 +57,16 @@ module.exports = function(Plugins) {
);
} else {
// handle hook's startsWith, i.e. action:homepage.get
var _parts = data.hook.split(':');
_parts.pop();
var _hook = _parts.join(':');
if (Plugins.deprecatedHooksParams[_hook]) {
winston.warn('[plugins/' + id + '] Hook `' + _hook + '` parameters: `' + Plugins.deprecatedHooksParams[_hook] + '`, are being deprecated, '
+ 'all plugins should now use the `middleware/cls` module instead of hook\'s arguments to get a reference to the `req`, `res` and/or `socket` object(s) (from which you can get the current `uid` if you need to.) '
+ '- for more info, visit https://docs.nodebb.org/en/latest/plugins/create.html#getting-a-reference-to-each-request-from-within-any-plugin-hook');
delete Plugins.deprecatedHooksParams[_hook];
var parts = data.hook.split(':');
if (parts.length > 2) {
parts.pop();
}
var hook = parts.join(':');
if (Plugins.deprecatedHooksParams[hook]) {
winston.warn('[plugins/' + id + '] Hook `' + hook + '` parameters: `' + Plugins.deprecatedHooksParams[hook] + '`, are being deprecated, '
+ 'all plugins should now use the `middleware/cls` module instead of hook\'s arguments to get a reference to the `http-request` or the `socket-request` object(s) (from which you can get the current `uid` if you need to.) '
+ '- for more info, visit https://docs.nodebb.org/en/latest/plugins/create.html#getting-a-reference-to-each-request-from-within-any-plugin-hook\n');
delete Plugins.deprecatedHooksParams[hook];
}
}
@@ -196,4 +198,4 @@ module.exports = function(Plugins) {
Plugins.hasListeners = function(hook) {
return !!(Plugins.loadedHooks[hook] && Plugins.loadedHooks[hook].length > 0);
};
};
};