Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #9492, keep query params on redirect

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-04-15 12:43:28 -04:00
parent 0cfccee3bd
commit 36f119a96a
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/middleware/user.js
View File

@@ -194,9 +194,8 @@ module.exports = function (middleware) {
if (!userslug) { if (!userslug) {
return next(); return next();
} }
const path = req.path.replace(/^\/api/, '') const path = req.url.replace(/^\/api/, '')
.replace('uid', 'user') .replace(`/uid/${uid}`, () => `/user/${userslug}`);
.replace(uid, () => userslug);
controllers.helpers.redirect(res, path); controllers.helpers.redirect(res, path);
}); });

10
test/controllers.js
View File

@@ -1050,6 +1050,16 @@ describe('Controllers', () => {
}); });
}); });
it('should redirect to userslug and keep query params', (done) => {
request(`${nconf.get('url')}/api/uid/${fooUid}/topics?foo=bar`, { json: true }, (err, res, body) => {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert.equal(res.headers['x-redirect'], '/user/foo/topics?foo=bar');
assert.equal(body, '/user/foo/topics?foo=bar');
done();
});
});
it('should 404 if user does not exist', (done) => { it('should 404 if user does not exist', (done) => {
request(`${nconf.get('url')}/api/uid/123123`, { json: true }, (err, res) => { request(`${nconf.get('url')}/api/uid/123123`, { json: true }, (err, res) => {
assert.ifError(err); assert.ifError(err);