Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: flag list tests due to breaking change in API

Browse Source
This commit is contained in:
Julian Lam
2020-08-19 08:38:09 -04:00
parent 07ebc81a2f
commit 360aa00d5a
1 changed files with 41 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
test/flags.js
View File

@@ -144,7 +144,10 @@ describe('Flags', function () {
describe('.list()', function () { describe('.list()', function () {
it('should show a list of flags (with one item)', function (done) { it('should show a list of flags (with one item)', function (done) {
Flags.list({}, 1, function (err, payload) { Flags.list({
filters: {},
uid: 1,
}, function (err, payload) {
assert.ifError(err); assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags')); assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page')); assert.ok(payload.hasOwnProperty('page'));
@@ -164,8 +167,11 @@ describe('Flags', function () {
describe('(with filters)', function () { describe('(with filters)', function () {
it('should return a filtered list of flags if said filters are passed in', function (done) { it('should return a filtered list of flags if said filters are passed in', function (done) {
Flags.list({ Flags.list({
filters: {
state: 'open', state: 'open',
}, 1, function (err, payload) { },
uid: 1,
}, function (err, payload) {
assert.ifError(err); assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags')); assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page')); assert.ok(payload.hasOwnProperty('page'));
@@ -178,8 +184,11 @@ describe('Flags', function () {
it('should return no flags if a filter with no matching flags is used', function (done) { it('should return no flags if a filter with no matching flags is used', function (done) {
Flags.list({ Flags.list({
filters: {
state: 'rejected', state: 'rejected',
}, 1, function (err, payload) { },
uid: 1,
}, function (err, payload) {
assert.ifError(err); assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags')); assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page')); assert.ok(payload.hasOwnProperty('page'));
@@ -192,8 +201,11 @@ describe('Flags', function () {
it('should return a flag when filtered by cid 1', function (done) { it('should return a flag when filtered by cid 1', function (done) {
Flags.list({ Flags.list({
filters: {
cid: 1, cid: 1,
}, 1, function (err, payload) { },
uid: 1,
}, function (err, payload) {
assert.ifError(err); assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags')); assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page')); assert.ok(payload.hasOwnProperty('page'));
@@ -206,8 +218,11 @@ describe('Flags', function () {
it('shouldn\'t return a flag when filtered by cid 2', function (done) { it('shouldn\'t return a flag when filtered by cid 2', function (done) {
Flags.list({ Flags.list({
filters: {
cid: 2, cid: 2,
}, 1, function (err, payload) { },
uid: 1,
}, function (err, payload) {
assert.ifError(err); assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags')); assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page')); assert.ok(payload.hasOwnProperty('page'));
@@ -220,8 +235,11 @@ describe('Flags', function () {
it('should return a flag when filtered by both cid 1 and 2', function (done) { it('should return a flag when filtered by both cid 1 and 2', function (done) {
Flags.list({ Flags.list({
filters: {
cid: [1, 2], cid: [1, 2],
}, 1, function (err, payload) { },
uid: 1,
}, function (err, payload) {
assert.ifError(err); assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags')); assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page')); assert.ok(payload.hasOwnProperty('page'));
@@ -234,9 +252,12 @@ describe('Flags', function () {
it('should return one flag if filtered by both cid 1 and 2 and open state', function (done) { it('should return one flag if filtered by both cid 1 and 2 and open state', function (done) {
Flags.list({ Flags.list({
filters: {
cid: [1, 2], cid: [1, 2],
state: 'open', state: 'open',
}, 1, function (err, payload) { },
uid: 1,
}, function (err, payload) {
assert.ifError(err); assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags')); assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page')); assert.ok(payload.hasOwnProperty('page'));
@@ -249,9 +270,12 @@ describe('Flags', function () {
it('should return no flag if filtered by both cid 1 and 2 and non-open state', function (done) { it('should return no flag if filtered by both cid 1 and 2 and non-open state', function (done) {
Flags.list({ Flags.list({
filters: {
cid: [1, 2], cid: [1, 2],
state: 'resolved', state: 'resolved',
}, 1, function (err, payload) { },
uid: 1,
}, function (err, payload) {
assert.ifError(err); assert.ifError(err);
assert.ok(payload.hasOwnProperty('flags')); assert.ok(payload.hasOwnProperty('flags'));
assert.ok(payload.hasOwnProperty('page')); assert.ok(payload.hasOwnProperty('page'));