chore: re-order interstitial tests so email and gdpr tests are in sub-blocks

test/controllers.js

@@ -332,173 +332,194 @@ describe('Controllers', () => {
 		});
 	});
 
-	describe('registration interstitials', () => {
+	describe.only('registration interstitials', () => {
-		let jar;
+		describe('email update', () => {
-		let token;
+			let jar;
+			let token;
 
-		it('email interstitial should still apply if empty email entered and requireEmailAddress is enabled', async () => {
+			before(async () => {
-			meta.config.requireEmailAddress = 1;
+				jar = await helpers.registerUser({
+					username: utils.generateUUID().slice(0, 10),
+					password: utils.generateUUID(),
+				});
+				console.log(jar);
+				token = await helpers.getCsrfToken(jar);
 
-			jar = await helpers.registerUser({
+				meta.config.requireEmailAddress = 1;
-				username: 'testEmailReg',
-				password: 'asdasd',
 			});
-			token = await helpers.getCsrfToken(jar);
 
-			let res = await requestAsync(`${nconf.get('url')}/register/complete`, {
+			after(() => {
-				method: 'post',
+				meta.config.requireEmailAddress = 0;
-				jar,
+			});
-				json: true,
+
-				followRedirect: false,
+			it('email interstitial should still apply if empty email entered and requireEmailAddress is enabled', async () => {
-				simple: false,
+				let res = await requestAsync(`${nconf.get('url')}/register/complete`, {
-				resolveWithFullResponse: true,
+					method: 'post',
-				headers: {
+					jar,
-					'x-csrf-token': token,
+					json: true,
-				},
+					followRedirect: false,
-				form: {
+					simple: false,
+					resolveWithFullResponse: true,
+					headers: {
+						'x-csrf-token': token,
+					},
+					form: {
+						email: '',
+					},
+				});
+
+				assert.strictEqual(res.headers.location, `${nconf.get('relative_path')}/register/complete`);
+
+				res = await requestAsync(`${nconf.get('url')}/api/register/complete`, {
+					jar,
+					json: true,
+					resolveWithFullResponse: true,
+				});
+				assert.strictEqual(res.statusCode, 200);
+				assert(res.body.errors.length);
+				assert(res.body.errors.includes('[[error:invalid-email]]'));
+			});
+
+			it('gdpr interstitial should still apply if email requirement is disabled', async () => {
+				meta.config.requireEmailAddress = 0;
+
+				const res = await requestAsync(`${nconf.get('url')}/api/register/complete`, {
+					jar,
+					json: true,
+					resolveWithFullResponse: true,
+				});
+
+				assert(!res.body.errors.includes('[[error:invalid-email]]'));
+				assert(!res.body.errors.includes('[[error:gdpr_consent_denied]]'));
+			});
+
+			it('should error if userData is falsy', async () => {
+				try {
+					await user.interstitials.email({ userData: null });
+					assert(false);
+				} catch (err) {
+					assert.strictEqual(err.message, '[[error:invalid-data]]');
+				}
+			});
+
+			it('should throw error if email is not valid', async () => {
+				const uid = await user.create({ username: 'interstiuser1' });
+				try {
+					const result = await user.interstitials.email({
+						userData: { uid: uid, updateEmail: true },
+						req: { uid: uid },
+						interstitials: [],
+					});
+					assert.strictEqual(result.interstitials[0].template, 'partials/email_update');
+					await result.interstitials[0].callback({ uid: uid }, {
+						email: 'invalidEmail',
+					});
+					assert(false);
+				} catch (err) {
+					assert.strictEqual(err.message, '[[error:invalid-email]]');
+				}
+			});
+
+			it('should set req.session.emailChanged to 1', async () => {
+				const uid = await user.create({ username: 'interstiuser2' });
+				const result = await user.interstitials.email({
+					userData: { uid: uid, updateEmail: true },
+					req: { uid: uid, session: {} },
+					interstitials: [],
+				});
+
+				await result.interstitials[0].callback({ uid: uid }, {
+					email: 'interstiuser2@nodebb.org',
+				});
+				assert.strictEqual(result.req.session.emailChanged, 1);
+			});
+
+			it('should set email if admin is changing it', async () => {
+				const uid = await user.create({ username: 'interstiuser3' });
+				const result = await user.interstitials.email({
+					userData: { uid: uid, updateEmail: true },
+					req: { uid: adminUid },
+					interstitials: [],
+				});
+
+				await result.interstitials[0].callback({ uid: uid }, {
+					email: 'interstiuser3@nodebb.org',
+				});
+				const userData = await user.getUserData(uid);
+				assert.strictEqual(userData.email, 'interstiuser3@nodebb.org');
+				assert.strictEqual(userData['email:confirmed'], 1);
+			});
+
+			it('should throw error if user tries to edit other users email', async () => {
+				const uid = await user.create({ username: 'interstiuser4' });
+				try {
+					const result = await user.interstitials.email({
+						userData: { uid: uid, updateEmail: true },
+						req: { uid: 1000 },
+						interstitials: [],
+					});
+
+					await result.interstitials[0].callback({ uid: uid }, {
+						email: 'derp@derp.com',
+					});
+					assert(false);
+				} catch (err) {
+					assert.strictEqual(err.message, '[[error:no-privileges]]');
+				}
+			});
+
+			it('should remove current email', async () => {
+				const uid = await user.create({ username: 'interstiuser5' });
+				await user.setUserField(uid, 'email', 'interstiuser5@nodebb.org');
+				await user.email.confirmByUid(uid);
+
+				const result = await user.interstitials.email({
+					userData: { uid: uid, updateEmail: true },
+					req: { uid: uid, session: { id: 0 } },
+					interstitials: [],
+				});
+
+				await result.interstitials[0].callback({ uid: uid }, {
 					email: '',
-				},
-			});
-
-			assert.strictEqual(res.headers.location, `${nconf.get('relative_path')}/register/complete`);
-
-			res = await requestAsync(`${nconf.get('url')}/api/register/complete`, {
-				jar,
-				json: true,
-				resolveWithFullResponse: true,
-			});
-			console.log(res.statusCode, JSON.stringify(res.body, null, 4));
-			assert.strictEqual(res.statusCode, 200);
-			assert(res.body.errors.length);
-			assert(res.body.errors.includes('[[error:invalid-email]]'));
-		});
-
-		it('gdpr interstitial should still apply if email requirement is disabled', async () => {
-			meta.config.requireEmailAddress = 0;
-
-			const res = await requestAsync(`${nconf.get('url')}/api/register/complete`, {
-				jar,
-				json: true,
-				resolveWithFullResponse: true,
-			});
-
-			assert(!res.body.errors.includes('[[error:invalid-email]]'));
-			assert(!res.body.errors.includes('[[error:gdpr_consent_denied]]'));
-		});
-
-		it('registration should succeed once gdpr prompts are agreed to', async () => {
-			const res = await requestAsync(`${nconf.get('url')}/register/complete`, {
-				method: 'post',
-				jar,
-				json: true,
-				followRedirect: false,
-				simple: false,
-				resolveWithFullResponse: true,
-				headers: {
-					'x-csrf-token': token,
-				},
-				form: {
-					gdpr_agree_data: 'on',
-					gdpr_agree_email: 'on',
-				},
-			});
-
-			assert.strictEqual(res.statusCode, 302);
-			assert.strictEqual(res.headers.location, `${nconf.get('relative_path')}/`);
-		});
-
-		it('should error if userData is falsy', async () => {
-			try {
-				await user.interstitials.email({ userData: null });
-				assert(false);
-			} catch (err) {
-				assert.strictEqual(err.message, '[[error:invalid-data]]');
-			}
-		});
-
-		it('should throw error if email is not valid', async () => {
-			const uid = await user.create({ username: 'interstiuser1' });
-			try {
-				const result = await user.interstitials.email({
-					userData: { uid: uid, updateEmail: true },
-					req: { uid: uid },
-					interstitials: [],
 				});
-				assert.strictEqual(result.interstitials[0].template, 'partials/email_update');
+				const userData = await user.getUserData(uid);
-				await result.interstitials[0].callback({ uid: uid }, {
+				assert.strictEqual(userData.email, '');
-					email: 'invalidEmail',
+				assert.strictEqual(userData['email:confirmed'], 0);
+			});
+		});
+
+		describe('gdpr', () => {
+			let jar;
+			let token;
+
+			before(async () => {
+				jar = await helpers.registerUser({
+					username: utils.generateUUID(),
+					password: utils.generateUUID(),
 				});
-				assert(false);
+				token = await helpers.getCsrfToken(jar);
-			} catch (err) {
-				assert.strictEqual(err.message, '[[error:invalid-email]]');
-			}
-		});
-
-		it('should set req.session.emailChanged to 1', async () => {
-			const uid = await user.create({ username: 'interstiuser2' });
-			const result = await user.interstitials.email({
-				userData: { uid: uid, updateEmail: true },
-				req: { uid: uid, session: {} },
-				interstitials: [],
 			});
 
-			await result.interstitials[0].callback({ uid: uid }, {
+			it('registration should succeed once gdpr prompts are agreed to', async () => {
-				email: 'interstiuser2@nodebb.org',
+				const res = await requestAsync(`${nconf.get('url')}/register/complete`, {
-			});
+					method: 'post',
-			assert.strictEqual(result.req.session.emailChanged, 1);
+					jar,
-		});
+					json: true,
-
+					followRedirect: false,
-		it('should set email if admin is changing it', async () => {
+					simple: false,
-			const uid = await user.create({ username: 'interstiuser3' });
+					resolveWithFullResponse: true,
-			const result = await user.interstitials.email({
+					headers: {
-				userData: { uid: uid, updateEmail: true },
+						'x-csrf-token': token,
-				req: { uid: adminUid },
+					},
-				interstitials: [],
+					form: {
-			});
+						gdpr_agree_data: 'on',
-
+						gdpr_agree_email: 'on',
-			await result.interstitials[0].callback({ uid: uid }, {
+					},
-				email: 'interstiuser3@nodebb.org',
-			});
-			const userData = await user.getUserData(uid);
-			assert.strictEqual(userData.email, 'interstiuser3@nodebb.org');
-			assert.strictEqual(userData['email:confirmed'], 1);
-		});
-
-		it('should throw error if user tries to edit other users email', async () => {
-			const uid = await user.create({ username: 'interstiuser4' });
-			try {
-				const result = await user.interstitials.email({
-					userData: { uid: uid, updateEmail: true },
-					req: { uid: 1000 },
-					interstitials: [],
 				});
 
-				await result.interstitials[0].callback({ uid: uid }, {
+				assert.strictEqual(res.statusCode, 302);
-					email: 'derp@derp.com',
+				assert.strictEqual(res.headers.location, `${nconf.get('relative_path')}/`);
-				});
-				assert(false);
-			} catch (err) {
-				assert.strictEqual(err.message, '[[error:no-privileges]]');
-			}
-		});
-
-		it('should remove current email', async () => {
-			const uid = await user.create({ username: 'interstiuser5' });
-			await user.setUserField(uid, 'email', 'interstiuser5@nodebb.org');
-			await user.email.confirmByUid(uid);
-
-			const result = await user.interstitials.email({
-				userData: { uid: uid, updateEmail: true },
-				req: { uid: uid, session: { id: 0 } },
-				interstitials: [],
 			});
-
-			await result.interstitials[0].callback({ uid: uid }, {
-				email: '',
-			});
-			const userData = await user.getUserData(uid);
-			assert.strictEqual(userData.email, '');
-			assert.strictEqual(userData['email:confirmed'], 0);
 		});
 	});
 

test/helpers/index.js

@@ -167,6 +167,7 @@ helpers.registerUser = function (data, callback) {
 				'x-csrf-token': body.csrf_token,
 			},
 		}, (err, response, body) => {
+			console.log(body);
 			callback(err, jar, response, body);
 		});
 	});