closes #3436

src/controllers/admin/users.js

@@ -1,8 +1,10 @@
 "use strict";
 
-var async = require('async'),
-	user = require('../../user'),
-	meta = require('../../meta');
+var async = require('async');
+var user = require('../../user');
+var meta = require('../../meta');
+var db = require('../../database');
+var pagination = require('../../pagination');
 
 
 var usersController = {};
@@ -10,25 +12,68 @@ var usersController = {};
 usersController.search = function(req, res, next) {
 	res.render('admin/manage/users', {
 		search_display: '',
-		loadmore_display: 'hide',
 		users: []
 	});
 };
 
-usersController.sortByPosts = function(req, res, next) {
-	getUsers('users:postcount', req, res, next);
-};
-
-usersController.sortByReputation = function(req, res, next) {
-	getUsers('users:reputation', req, res, next);
-};
-
 usersController.sortByJoinDate = function(req, res, next) {
-	getUsers('users:joindate', req, res, next);
+	getUsers('users:joindate', 'latest', req, res, next);
 };
 
+usersController.notValidated = function(req, res, next) {
+	getUsers('users:notvalidated', 'notvalidated', req, res, next);
+};
+
+usersController.noPosts = function(req, res, next) {
+	getUsersByScore('users:postcount', 'noposts', 0, 0, req, res, next);
+};
+
+usersController.inactive = function(req, res, next) {
+	var timeRange = 1000 * 60 * 60 * 24 * 30 * (parseInt(req.query.months, 10) || 3);
+	var cutoff = Date.now() - timeRange;
+	getUsersByScore('users:online', 'inactive', 0, cutoff, req, res, next);
+};
+
+function getUsersByScore(set, section, min, max, req, res, callback) {
+	var page = parseInt(req.query.page, 10) || 1;
+	var resultsPerPage = 25;
+	var start = Math.max(0, page - 1) * resultsPerPage;
+	var count = 0;
+
+	async.waterfall([
+		function (next) {
+			async.parallel({
+				count: function (next) {
+					db.sortedSetCount(set, min, max, next);
+				},
+				uids: function (next) {
+					db.getSortedSetRevRangeByScore(set, start, resultsPerPage, max, min, next);
+				}
+			}, next);
+		},
+		function (results, next) {
+			count = results.count;
+			user.getUsers(results.uids, req.uid, next);
+		}
+	], function(err, users) {
+		if (err) {
+			return callback(err);
+		}
+		users = users.filter(function(user) {
+			return user && parseInt(user.uid, 10);
+		});
+		var data = {
+			users: users,
+			page: page,
+			pageCount: Math.ceil(count / resultsPerPage)
+		};
+		data[section] = true;
+		render(req, res, data);
+	});
+}
+
 usersController.banned = function(req, res, next) {
-	getUsers('users:banned', req, res, next);
+	getUsers('users:banned', 'banned', req, res, next);
 };
 
 usersController.registrationQueue = function(req, res, next) {
@@ -75,29 +120,46 @@ usersController.registrationQueue = function(req, res, next) {
 		}
 		res.render('admin/manage/registration', data);
 	});
-
 };
 
-function getUsers(set, req, res, next) {
-	user.getUsersFromSet(set, req.uid, 0, 49, function(err, users) {
+function getUsers(set, section, req, res, next) {
+	var page = parseInt(req.query.page, 10) || 1;
+	var resultsPerPage = 25;
+	var start = Math.max(0, page - 1) * resultsPerPage;
+	var stop = start + resultsPerPage - 1;
+
+	async.parallel({
+		count: function(next) {
+			db.sortedSetCard(set, next);
+		},
+		users: function(next) {
+			user.getUsersFromSet(set, req.uid, start, stop, next);
+		}
+	}, function(err, results) {
 		if (err) {
 			return next(err);
 		}
 
-		users = users.filter(function(user) {
+		results.users = results.users.filter(function(user) {
 			return user && parseInt(user.uid, 10);
 		});
-
-		res.render('admin/manage/users', {
-			search_display: 'hidden',
-			loadmore_display: 'block',
-			users: users,
-			yourid: req.uid,
-			requireEmailConfirmation: parseInt(meta.config.requireEmailConfirmation, 10) === 1
-		});
+		var data = {
+			users: results.users,
+			page: page,
+			pageCount: Math.ceil(results.count / resultsPerPage)
+		};
+		data[section] = true;
+		render(req, res, data);
 	});
 }
 
+function render(req, res, data) {
+	data.search_display = 'hidden';
+	data.pagination = pagination.create(data.page, data.pageCount, req.query);
+	data.requireEmailConfirmation = parseInt(meta.config.requireEmailConfirmation, 10) === 1;
+	res.render('admin/manage/users', data);
+}
+
 usersController.getCSV = function(req, res, next) {
 	user.getUsersCSV(function(err, data) {
 		if (err) {