Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: bookmark scroll doing ajaxify

Browse Source 
if target post is already on page
fix alerts crash due to double close
This commit is contained in:
Barış Soner Uşaklı
2023-08-21 20:18:56 -04:00
parent a7a266d72c
commit 2e0964e6fe
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
public/src/client/topic.js
View File

@@ -162,7 +162,7 @@ define('forum/topic', [
timeout: 15000, timeout: 15000,
type: 'info', type: 'info',
clickfn: function () { clickfn: function () {
navigator.scrollToIndex(parseInt(bookmark, 10), true); navigator.scrollToIndex(Math.max(0, parseInt(bookmark, 10) - 1), true);
}, },
closefn: function () { closefn: function () {
storage.removeItem('topic:' + tid + ':bookmark'); storage.removeItem('topic:' + tid + ':bookmark');

4
public/src/modules/alerts.js
View File

@@ -90,8 +90,8 @@ function updateAlert(alert, params) {
.on('click', function (e) { .on('click', function (e) {
if (!$(e.target).is('.btn-close')) { if (!$(e.target).is('.btn-close')) {
params.clickfn(); params.clickfn();
close(alert);
} }
close(alert);
}); });
} }
} }
@@ -128,8 +128,8 @@ function createNew(params) {
.on('click', function (e) { .on('click', function (e) {
if (!$(e.target).is('.btn-close')) { if (!$(e.target).is('.btn-close')) {
params.clickfn(alert, params); params.clickfn(alert, params);
close(alert);
} }
close(alert);
}); });
} }