Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: preserve order when changing parent

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-03-20 15:51:34 -04:00
parent 3c4e93a3c1
commit 2ceda70a97
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/categories/update.js
View File

@@ -69,10 +69,11 @@ module.exports = function (Categories) {
if (childrenCids.includes(newParent)) { if (childrenCids.includes(newParent)) {
throw new Error('[[error:cant-set-child-as-parent]]'); throw new Error('[[error:cant-set-child-as-parent]]');
} }
const oldParent = await Categories.getCategoryField(cid, 'parentCid'); const categoryData = await Categories.getCategoryFields(cid, ['parentCid', 'order']);
const oldParent = categoryData.parentCid;
await Promise.all([ await Promise.all([
db.sortedSetRemove(`cid:${oldParent}:children`, cid), db.sortedSetRemove(`cid:${oldParent}:children`, cid),
db.sortedSetAdd(`cid:${newParent}:children`, cid, cid), db.sortedSetAdd(`cid:${newParent}:children`, categoryData.order, cid),
db.setObjectField(`category:${cid}`, 'parentCid', newParent), db.setObjectField(`category:${cid}`, 'parentCid', newParent),
]); ]);