Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: change chat notification delivery

Browse Source 
instead of checking if user is online in the past x minutes, check if the user has read the room, if they have already marked the chat as read don't send notification
This commit is contained in:
Barış Soner Uşaklı
2023-03-26 21:13:07 -04:00
parent 2a9b3ee464
commit 2c5a5bf366
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/messaging/notifications.js
View File

@@ -57,8 +57,9 @@ module.exports = function (Messaging) {
};
async function sendNotifications(fromuid, uids, roomId, messageObj) {
const isOnline = await user.isOnline(uids);
uids = uids.filter((uid, index) => !isOnline[index] && parseInt(fromuid, 10) !== parseInt(uid, 10));
const hasRead = await Messaging.hasRead(uids, roomId);
uids = uids.filter((uid, index) => !hasRead[index] && parseInt(fromuid, 10) !== parseInt(uid, 10));
console.log('checking notif', uids, hasRead);
if (!uids.length) {
delete Messaging.notifyQueue[`${fromuid}:${roomId}`];
return;

9
src/messaging/unread.js
View File

@@ -21,9 +21,18 @@ module.exports = function (Messaging) {
};
Messaging.markRead = async (uid, roomId) => {
console.log('mark read :)', uid, roomId);
await db.sortedSetRemove(`uid:${uid}:chat:rooms:unread`, roomId);
};
Messaging.hasRead = async (uids, roomId) => {
const isMembers = await db.isMemberOfSortedSets(
uids.map(uid => `uid:${uid}:chat:rooms:unread`),
roomId
);
return uids.map((uid, index) => !isMembers[index]);
};
Messaging.markAllRead = async (uid) => {
await db.delete(`uid:${uid}:chat:rooms:unread`);
};