Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-02 03:55:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Memory leak & connection flood when access /admin/advanced/database

Browse Source
This commit is contained in:
Nguyen Trung Quan
2016-10-07 11:14:28 +07:00
parent b82670e005
commit 279559ff97
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/controllers/admin/database.js
View File

@@ -12,7 +12,17 @@ databaseController.get = function(req, res, next) {
redis: function(next) {
if (nconf.get('redis')) {
var rdb = require('../../database/redis');
var cxn = rdb.connect();
// var cxn = rdb.connect();
// Do not create new client if it exist.
// This will cause memory leak & connection flood
var cxn = rdb.client;
// Redis was initalized.
// Check cxn is unnecessary.
// if (!cxn) {
// cxn = rdb.client;
// rdb.client = cxn;
// }
rdb.info(cxn, next);
} else {
next();

8
src/database/mongo.js
View File

@@ -111,8 +111,14 @@
db: db
});
} else {
// Initial Redis database
var rdb = require('./redis');
// Create a new redis connection and store it in module (skeleton)
rdb.client = rdb.connect();
//
module.sessionStore = new sessionStore({
client: require('./redis').connect(),
client: rdb.client,
ttl: 60 * 60 * 24 * 14
});
}