Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 09:06:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf: cleanup sessions every 30 seconds

Browse Source 
instead of everytime addSession is called
This commit is contained in:
Barış Soner Uşaklı
2024-06-26 14:16:41 -04:00
parent 69ce3bf0b8
commit 26feb2bbf8
1 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/user/auth.js
View File

@@ -2,6 +2,8 @@
const validator = require('validator'); const validator = require('validator');
const _ = require('lodash'); const _ = require('lodash');
const winston = require('winston');
const cronJob = require('cron').CronJob;
const db = require('../database'); const db = require('../database');
const meta = require('../meta'); const meta = require('../meta');
const events = require('../events'); const events = require('../events');
@@ -11,6 +13,21 @@ const utils = require('../utils');
module.exports = function (User) { module.exports = function (User) {
User.auth = {}; User.auth = {};
const uidsToClean = Object.create(null);
new cronJob('*/30 * * * * *', (async () => {
const uids = Object.keys(uidsToClean);
try {
await Promise.all(uids.map(async (uid) => {
await cleanExpiredSessions(uid);
await revokeSessionsAboveThreshold(uid);
delete uidsToClean[uid];
}));
} catch (err) {
winston.error(err.stack);
}
}), null, true);
User.auth.logAttempt = async function (uid, ip) { User.auth.logAttempt = async function (uid, ip) {
if (!(parseInt(uid, 10) > 0)) { if (!(parseInt(uid, 10) > 0)) {
return; return;
@@ -101,12 +118,12 @@ module.exports = function (User) {
if (!(parseInt(uid, 10) > 0)) { if (!(parseInt(uid, 10) > 0)) {
return; return;
} }
await cleanExpiredSessions(uid); const now = Date.now();
uidsToClean[uid] = now;
await Promise.all([ await Promise.all([
db.sortedSetAdd(`uid:${uid}:sessions`, Date.now(), sessionId), db.sortedSetAdd(`uid:${uid}:sessions`, now, sessionId),
db.setObjectField(`uid:${uid}:sessionUUID:sessionId`, uuid, sessionId), db.setObjectField(`uid:${uid}:sessionUUID:sessionId`, uuid, sessionId),
]); ]);
await revokeSessionsAboveThreshold(uid);
}; };
async function revokeSessionsAboveThreshold(uid) { async function revokeSessionsAboveThreshold(uid) {