Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 03:26:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

use includes instead of indexOf

Browse Source 
use _.uniq instead of filter&indexOf
This commit is contained in:
Barış Soner Uşaklı
2018-10-20 14:40:48 -04:00
parent a6c70412db
commit 26d4e0852f
57 changed files with 156 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/controllers-admin.js
View File

@@ -481,9 +481,9 @@ describe('Admin Controllers', function () {
body = body.posts.map(function (network) {
return network && network.id;
});
assert(body.indexOf('facebook') !== -1);
assert(body.indexOf('twitter') !== -1);
assert(body.indexOf('google') !== -1);
assert(body.includes('facebook'));
assert(body.includes('twitter'));
assert(body.includes('google'));
done();
});
});
@@ -665,16 +665,16 @@ describe('Admin Controllers', function () {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
assert(body.indexOf('"someValue":"\\\\"foo\\\\""') !== -1);
assert(body.indexOf('"otherValue":"\\\'123\\\'"') !== -1);
assert(body.indexOf('"script":"<\\/script>"') !== -1);
assert(body.includes('"someValue":"\\\\"foo\\\\""'));
assert(body.includes('"otherValue":"\\\'123\\\'"'));
assert(body.includes('"script":"<\\/script>"'));
request(nconf.get('url'), { jar: jar }, function (err, res, body) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
assert(body);
assert(body.indexOf('"someValue":"\\\\"foo\\\\""') !== -1);
assert(body.indexOf('"otherValue":"\\\'123\\\'"') !== -1);
assert(body.indexOf('"script":"<\\/script>"') !== -1);
assert(body.includes('"someValue":"\\\\"foo\\\\""'));
assert(body.includes('"otherValue":"\\\'123\\\'"'));
assert(body.includes('"script":"<\\/script>"'));
plugins.unregisterHook('somePlugin', 'filter:config.get', onConfigGet);
done();
});