Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-03 04:25:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

use includes instead of indexOf

Browse Source 
use _.uniq instead of filter&indexOf
This commit is contained in:
Barış Soner Uşaklı
2018-10-20 14:40:48 -04:00
parent a6c70412db
commit 26d4e0852f
57 changed files with 156 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/upgrade.js
View File

@@ -87,7 +87,7 @@ Upgrade.check = function (callback) {
}
var remainder = files.filter(function (name) {
return executed.indexOf(path.basename(name, '.js')) === -1;
return !executed.includes(path.basename(name, '.js'));
});
next(remainder.length > 0 ? new Error('schema-out-of-date') : null);
@@ -112,7 +112,7 @@ Upgrade.run = function (callback) {
}
queue = data.available.reduce(function (memo, cur) {
if (data.completed.indexOf(path.basename(cur, '.js')) === -1) {
if (!data.completed.includes(path.basename(cur, '.js'))) {
memo.push(cur);
} else {
skipped += 1;
@@ -132,7 +132,7 @@ Upgrade.runParticular = function (names, callback) {
async.apply(file.walk, path.join(__dirname, './upgrades')),
function (files, next) {
var upgrades = files.filter(function (file) {
return names.indexOf(path.basename(file, '.js')) !== -1;
return names.includes(path.basename(file, '.js'));
});
Upgrade.process(upgrades, 0, next);