Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-04 21:15:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

use includes instead of indexOf

Browse Source 
use _.uniq instead of filter&indexOf
This commit is contained in:
Barış Soner Uşaklı
2018-10-20 14:40:48 -04:00
parent a6c70412db
commit 26d4e0852f
57 changed files with 156 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/topics/posts.js
View File

@@ -57,24 +57,20 @@ module.exports = function (Topics) {
}
function getPostUserData(field, method, callback) {
var uids = [];
var uidsMap = {};
postData.forEach(function (postData) {
if (postData && parseInt(postData[field], 10) >= 0 && uids.indexOf(postData[field]) === -1) {
uids.push(postData[field]);
postData.forEach((post) => {
if (post && parseInt(post[field], 10) >= 0) {
uidsMap[post[field]] = 1;
}
});
const uids = Object.keys(uidsMap);
async.waterfall([
function (next) {
method(uids, next);
},
function (users, next) {
var userData = {};
users.forEach(function (user, index) {
userData[uids[index]] = user;
});
next(null, userData);
next(null, _.zipObject(uids, users));
},
], callback);
}