Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-08 06:55:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

use includes instead of indexOf

Browse Source 
use _.uniq instead of filter&indexOf
This commit is contained in:
Barış Soner Uşaklı
2018-10-20 14:40:48 -04:00
parent a6c70412db
commit 26d4e0852f
57 changed files with 156 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/socket.io/categories.js
View File

@@ -47,7 +47,7 @@ SocketCategories.getWatchedCategories = function (socket, data, callback) {
},
function (results, next) {
var watchedCategories = results.categories.filter(function (category) {
return category && results.ignoredCids.indexOf(category.cid.toString()) === -1;
return category && !results.ignoredCids.includes(String(category.cid));
});
next(null, watchedCategories);
@@ -197,7 +197,7 @@ function ignoreOrWatch(fn, socket, cid, callback) {
var cat;
do {
cat = categoryData.find(function (c) {
return cids.indexOf(c.cid) === -1 && cids.indexOf(c.parentCid) !== -1;
return !cids.includes(c.cid) && cids.includes(c.parentCid);
});
if (cat) {
cids.push(cat.cid);