Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #12732 editing of remote post content

Browse Source 
title can now be edited, post content is not-editable.
This commit is contained in:
Julian Lam
2024-08-13 15:12:57 -04:00
parent 3474712228
commit 25bf97ae28
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/api/posts.js
View File

@@ -90,17 +90,25 @@ postsAPI.edit = async function (caller, data) {
if (!caller.uid) {
throw new Error('[[error:not-logged-in]]');
}
// Trim and remove HTML (latter for composers that send in HTML, like redactor)
const contentLen = utils.stripHTMLTags(data.content).trim().length;
// Discard content for non-local posts
if (!utils.isNumber(data.pid)) {
data.content = null;
} else {
// Trim and remove HTML (latter for composers that send in HTML, like redactor)
const contentLen = utils.stripHTMLTags(data.content).trim().length;
if (meta.config.minimumPostLength !== 0 && contentLen < meta.config.minimumPostLength) {
throw new Error(`[[error:content-too-short, ${meta.config.minimumPostLength}]]`);
} else if (contentLen > meta.config.maximumPostLength) {
throw new Error(`[[error:content-too-long, ${meta.config.maximumPostLength}]]`);
}
}
if (data.title && data.title.length < meta.config.minimumTitleLength) {
throw new Error(`[[error:title-too-short, ${meta.config.minimumTitleLength}]]`);
} else if (data.title && data.title.length > meta.config.maximumTitleLength) {
throw new Error(`[[error:title-too-long, ${meta.config.maximumTitleLength}]]`);
} else if (meta.config.minimumPostLength !== 0 && contentLen < meta.config.minimumPostLength) {
throw new Error(`[[error:content-too-short, ${meta.config.minimumPostLength}]]`);
} else if (contentLen > meta.config.maximumPostLength) {
throw new Error(`[[error:content-too-long, ${meta.config.maximumPostLength}]]`);
} else if (!await posts.canUserPostContentWithLinks(caller.uid, data.content)) {
throw new Error(`[[error:not-enough-reputation-to-post-links, ${meta.config['min:rep:post-links']}]]`);
}

3
src/posts/edit.js
View File

@@ -34,6 +34,7 @@ module.exports = function (Posts) {
await scheduledTopicCheck(data, topicData);
data.content = data.content === null ? postData.content : data.content;
const oldContent = postData.content; // for diffing purposes
const editPostData = getEditPostData(data, topicData, postData);
@@ -106,7 +107,7 @@ module.exports = function (Posts) {
const { tid } = postData;
const title = data.title ? data.title.trim() : '';
const isMain = parseInt(data.pid, 10) === parseInt(topicData.mainPid, 10);
const isMain = String(data.pid) === String(topicData.mainPid);
if (!isMain) {
return {
tid: tid,