Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 11:35:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't crash if tid is falsy

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-11-30 15:47:19 -05:00
parent 0414356cf7
commit 1cdb0b1e19
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/topics/posts.js
View File

@@ -22,7 +22,10 @@ module.exports = function (Topics) {
}; };
Topics.getTopicPosts = async function (topicOrTid, set, start, stop, uid, reverse) { Topics.getTopicPosts = async function (topicOrTid, set, start, stop, uid, reverse) {
if (topicOrTid && typeof topicOrTid !== 'object') { if (!topicOrTid) {
return [];
}
if (typeof topicOrTid !== 'object') {
// TODO: remove in 1.19.0 // TODO: remove in 1.19.0
winston.warn('[deprecated] Topics.getTopicPosts(tid, ...) usage is deprecated, pass a topic object as first argument!'); winston.warn('[deprecated] Topics.getTopicPosts(tid, ...) usage is deprecated, pass a topic object as first argument!');
topicOrTid = await Topics.getTopicData(topicOrTid); topicOrTid = await Topics.getTopicData(topicOrTid);

5
test/topics.js
View File

@@ -502,6 +502,11 @@ describe('Topic\'s', () => {
assert.strictEqual(post.index, index); assert.strictEqual(post.index, index);
}); });
}); });
it('should return empty array if first param is falsy', async () => {
const posts = await topics.getTopicPosts(null, `tid:${tid}:posts`, 0, 9, topic.userId, true);
assert.deepStrictEqual(posts, []);
});
}); });
}); });