Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 09:06:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: properly handle if mainPid is not a number

Browse Source
This commit is contained in:
Julian Lam
2024-02-29 00:06:59 -05:00
parent b529610bba
commit 1ca9994f43
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/activitypub/notes.js
View File

@@ -226,6 +226,7 @@ Notes.assertTopic = async (uid, id) => {
title = `${title.slice(0, meta.config.maximumTitleLength)}...`; title = `${title.slice(0, meta.config.maximumTitleLength)}...`;
} }
} }
mainPid = utils.isNumber(mainPid) ? parseInt(mainPid, 10) : mainPid;
// Privilege check for local categories // Privilege check for local categories
const privilege = `topics:${tid ? 'reply' : 'create'}`; const privilege = `topics:${tid ? 'reply' : 'create'}`;
@@ -245,8 +246,8 @@ Notes.assertTopic = async (uid, id) => {
]; ];
// mainPid doesn't belong in posts zset // mainPid doesn't belong in posts zset
if (ids.includes(parseInt(mainPid, 10))) { if (ids.includes(mainPid)) {
const idx = ids.indexOf(parseInt(mainPid, 10)); const idx = ids.indexOf(mainPid);
ids.splice(idx, 1); ids.splice(idx, 1);
timestamps.splice(idx, 1); timestamps.splice(idx, 1);
} }