Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-03 20:45:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: fine-grained privileges integration for fediverse users and world pseudo-category

Browse Source
This commit is contained in:
Julian Lam
2024-02-26 11:39:32 -05:00
parent 28370b1043
commit 1bd8f9a1fa
16 changed files with 186 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
src/activitypub/inbox.js
View File

@@ -4,6 +4,7 @@ const winston = require('winston');
const nconf = require('nconf');
const db = require('../database');
const privileges = require('../privileges');
const user = require('../user');
const posts = require('../posts');
const topics = require('../topics');
@@ -17,20 +18,14 @@ const inbox = module.exports;
inbox.create = async (req) => {
const { object } = req.body;
const postData = await activitypub.mocks.post(object);
// Temporary, reject non-public notes.
if (![...postData._activitypub.to, ...postData._activitypub.cc].includes(activitypub._constants.publicAddress)) {
if (![...object.to, ...object.cc].includes(activitypub._constants.publicAddress)) {
throw new Error('[[error:activitypub.not-implemented]]');
}
if (postData) {
await activitypub.notes.assert(0, [postData]);
const tid = await activitypub.notes.assertTopic(0, postData.pid);
winston.info(`[activitypub/inbox] Parsing note ${postData.pid} into topic ${tid}`);
} else {
winston.warn('[activitypub/inbox] Received object was not a note');
}
const tid = await activitypub.notes.assertTopic(0, object.id);
winston.info(`[activitypub/inbox] Parsing note ${object.id} into topic ${tid}`);
};
inbox.update = async (req) => {
@@ -43,6 +38,18 @@ inbox.update = async (req) => {
throw new Error('[[error:activitypub.origin-mismatch]]');
}
const [exists, allowed] = await Promise.all([
posts.exists(object.id),
privileges.posts.can('posts:edit', object.id, activitypub._constants.uid),
]);
if (!exists || !allowed) {
winston.info(`[activitypub/inbox.update] ${object.id} not allowed to be edited.`);
return activitypub.send('uid', 0, actor, {
type: 'Reject',
object,
});
}
switch (object.type) {
case 'Note': {
const postData = await activitypub.mocks.post(object);
@@ -70,6 +77,15 @@ inbox.like = async (req) => {
throw new Error('[[error:activitypub.invalid-id]]');
}
const allowed = await privileges.posts.can('posts:upvote', id, activitypub._constants.uid);
if (!allowed) {
winston.info(`[activitypub/inbox.like] ${id} not allowed to be upvoted.`);
return activitypub.send('uid', 0, actor, {
type: 'Reject',
object,
});
}
winston.info(`[activitypub/inbox/like] id ${id} via ${actor}`);
await posts.upvote(id, actor);
@@ -172,17 +188,29 @@ inbox.follow = async (req) => {
},
});
} else if (type === 'category') {
const exists = await categories.exists(id);
const [exists, allowed] = await Promise.all([
categories.exists(id),
privileges.categories.can('read', id, 'activitypub._constants.uid'),
]);
if (!exists) {
throw new Error('[[error:invalid-cid]]');
}
if (!allowed) {
return activitypub.send('uid', 0, req.body.actor, {
type: 'Reject',
object: {
type: 'Follow',
actor: req.body.actor,
},
});
}
const watchState = await categories.getWatchState([id], req.body.actor);
if (watchState[0] !== categories.watchStates.tracking) {
await user.setCategoryWatchState(req.body.actor, id, categories.watchStates.tracking);
}
await activitypub.send('cid', id, req.body.actor, {
activitypub.send('cid', id, req.body.actor, {
type: 'Accept',
object: {
type: 'Follow',
@@ -275,6 +303,16 @@ inbox.undo = async (req) => {
throw new Error('[[error:invalid-pid]]');
}
const allowed = await privileges.posts.can('posts:upvote', id, activitypub._constants.uid);
if (!allowed) {
winston.info(`[activitypub/inbox.like] ${id} not allowed to be upvoted.`);
activitypub.send('uid', 0, actor, {
type: 'Reject',
object,
});
break;
}
await posts.unvote(id, actor);
break;
}