Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-29 18:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

backwards compatibility with plugins that are assuming no callback

Browse Source
This commit is contained in:
Julian Lam
2014-03-10 16:58:16 -04:00
parent a7f310b49a
commit 19c9f1bb19
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
public/templates/.gitignore vendored
View File

@@ -1 +0,0 @@
*.tpl

11
src/plugins.js
View File

@@ -315,12 +315,17 @@ var fs = require('fs'),
case 'filter': case 'filter':
async.reduce(hookList, args, function(value, hookObj, next) { async.reduce(hookList, args, function(value, hookObj, next) {
if (hookObj.method) { if (hookObj.method) {
if (hookObj.callbacked) { if (!hookObj.hasOwnProperty('callbacked') || hookObj.callbacked === true) {
hookObj.method.apply(Plugins, value.concat(function() { var value = hookObj.method.apply(Plugins, value.concat(function() {
next(arguments[0], Array.prototype.slice.call(arguments, 1)); next(arguments[0], Array.prototype.slice.call(arguments, 1));
})); }));
if (value !== undefined) {
winston.warn('[plugins/' + hookObj.id + '] "callbacked" deprecated as of 0.4x. Use asynchronous method instead for hook: ' + hook);
next(null, [value]);
}
} else { } else {
winston.warn('[plugins] "callbacked" deprecated as of 0.4x. Use asynchronous method instead for hook: ' + hook); winston.warn('[plugins/' + hookObj.id + '] "callbacked" deprecated as of 0.4x. Use asynchronous method instead for hook: ' + hook);
value = hookObj.method.apply(Plugins, value); value = hookObj.method.apply(Plugins, value);
next(null, [value]); next(null, [value]);
} }