Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-12-20 07:20:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: get rid of post.exists check, if post doesnt exist content is falsy

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2025-10-30 20:34:01 -04:00
parent b5ea20898e
commit 179440372a
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/topics/posts.js
View File

@@ -184,9 +184,6 @@ module.exports = function (Topics) {
.filter(p => p && p.hasOwnProperty('toPid') && (activitypub.helpers.isUri(p.toPid) || utils.isNumber(p.toPid))) .filter(p => p && p.hasOwnProperty('toPid') && (activitypub.helpers.isUri(p.toPid) || utils.isNumber(p.toPid)))
.map(postObj => postObj.toPid); .map(postObj => postObj.toPid);
const exists = await posts.exists(parentPids);
parentPids = parentPids.filter((_, idx) => exists[idx]);
if (!parentPids.length) { if (!parentPids.length) {
return; return;
} }
@@ -212,7 +209,7 @@ module.exports = function (Topics) {
parentPost.content = foundPost.content; parentPost.content = foundPost.content;
return; return;
} }
parentPost = await posts.parsePost(parentPost); await posts.parsePost(parentPost);
})); }));
const parents = {}; const parents = {};
@@ -230,7 +227,7 @@ module.exports = function (Topics) {
}); });
postData.forEach((post) => { postData.forEach((post) => {
if (parents[post.toPid]) { if (parents[post.toPid] && parents[post.toPid].content) {
post.parent = parents[post.toPid]; post.parent = parents[post.toPid];
} }
}); });