Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-31 11:05:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use group.slug on acp group urls closes #8277

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2022-08-16 10:42:33 -04:00
parent b663c620ce
commit 14c79763dd
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/controllers/admin/groups.js
View File

@@ -9,6 +9,7 @@ const groups = require('../../groups');
const meta = require('../../meta'); const meta = require('../../meta');
const pagination = require('../../pagination'); const pagination = require('../../pagination');
const events = require('../../events'); const events = require('../../events');
const slugify = require('../../slugify');
const groupsController = module.exports; const groupsController = module.exports;
@@ -31,7 +32,8 @@ groupsController.list = async function (req, res) {
}; };
groupsController.get = async function (req, res, next) { groupsController.get = async function (req, res, next) {
const groupName = req.params.name; const slug = slugify(req.params.name);
const groupName = await groups.getGroupNameByGroupSlug(slug);
const [groupNames, group] = await Promise.all([ const [groupNames, group] = await Promise.all([
getGroupNames(), getGroupNames(),
groups.get(groupName, { uid: req.uid, truncateUserList: true, userListCount: 20 }), groups.get(groupName, { uid: req.uid, truncateUserList: true, userListCount: 20 }),

2
src/views/admin/manage/groups.tpl
View File

@@ -21,7 +21,7 @@
<!-- BEGIN groups --> <!-- BEGIN groups -->
<tr data-groupname="{groups.displayName}" data-name-encoded="{groups.nameEncoded}"> <tr data-groupname="{groups.displayName}" data-name-encoded="{groups.nameEncoded}">
<td> <td>
<a href="{config.relative_path}/admin/manage/groups/{groups.nameEncoded}">{groups.displayName}</a> ({groups.memberCount}) <a href="{config.relative_path}/admin/manage/groups/{groups.slug}">{groups.displayName}</a> ({groups.memberCount})
<p class="description">{groups.description}</p> <p class="description">{groups.description}</p>
</td> </td>
<td> <td>