Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 17:16:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #9730, show warning if plugin is active but not installed

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-08-23 21:27:03 -04:00
parent 096c5a5891
commit 13878e9f14
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/data.js
View File

@@ -13,11 +13,16 @@ const Data = module.exports;
const basePath = path.join(__dirname, '../../'); const basePath = path.join(__dirname, '../../');
Data.getPluginPaths = async function () { Data.getPluginPaths = async function () {
let plugins = await db.getSortedSetRange('plugins:active', 0, -1); const plugins = await db.getSortedSetRange('plugins:active', 0, -1);
plugins = plugins.filter(plugin => plugin && typeof plugin === 'string') const pluginPaths = plugins.filter(plugin => plugin && typeof plugin === 'string')
.map(plugin => path.join(paths.nodeModules, plugin)); .map(plugin => path.join(paths.nodeModules, plugin));
const exists = await Promise.all(plugins.map(p => file.exists(p))); const exists = await Promise.all(pluginPaths.map(file.exists));
exists.forEach((exists, i) => {
if (!exists) {
winston.warn(`[plugins] "${plugins[i]}" is active but not installed.`);
}
});
return plugins.filter((p, i) => exists[i]); return plugins.filter((p, i) => exists[i]);
}; };

4
src/upgrade.js
View File

@@ -71,7 +71,9 @@ Upgrade.appendPluginScripts = async function (files) {
}); });
} }
} catch (e) { } catch (e) {
winston.warn(`[upgrade/appendPluginScripts] Unable to read plugin.json for plugin \`${plugin}\`. Skipping.`); if (e.code !== 'MODULE_NOT_FOUND') {
winston.error(e.stack);
}
} }
}); });
return files; return files;