Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 03:26:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: client-side hooks for navigator scroll action

Browse Source
This commit is contained in:
Julian Lam
2022-09-19 14:27:35 -04:00
parent 664bc5f54d
commit 135fe55bed
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
public/src/modules/navigator.js
View File

@@ -561,12 +561,14 @@ define('navigator', ['forum/pagination', 'components', 'hooks', 'alerts'], funct
navigator.scrollToElement(scrollTo, highlight, duration, topicIndex); navigator.scrollToElement(scrollTo, highlight, duration, topicIndex);
}; };
navigator.scrollToElement = function (scrollTo, highlight, duration, newIndex = null) { navigator.scrollToElement = async (scrollTo, highlight, duration, newIndex = null) => {
if (!scrollTo.length) { if (!scrollTo.length) {
navigator.scrollActive = false; navigator.scrollActive = false;
return; return;
} }
await hooks.fire('filter:navigator.scroll', { scrollTo, highlight, duration, newIndex });
const postHeight = scrollTo.outerHeight(true); const postHeight = scrollTo.outerHeight(true);
const navbarHeight = components.get('navbar').outerHeight(true); const navbarHeight = components.get('navbar').outerHeight(true);
const topicHeaderHeight = $('.topic-header').outerHeight(true) || 0; const topicHeaderHeight = $('.topic-header').outerHeight(true) || 0;
@@ -584,6 +586,8 @@ define('navigator', ['forum/pagination', 'components', 'hooks', 'alerts'], funct
// Re-enable onScroll behaviour // Re-enable onScroll behaviour
setTimeout(() => { // fixes race condition from jQuery — onAnimateComplete called too quickly setTimeout(() => { // fixes race condition from jQuery — onAnimateComplete called too quickly
$(window).on('scroll', navigator.delayedUpdate); $(window).on('scroll', navigator.delayedUpdate);
hooks.fire('action:navigator.scrolled', { scrollTo, highlight, duration, newIndex });
}, 50); }, 50);
} }
function onAnimateComplete() { function onAnimateComplete() {