Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-27 17:16:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: removal of emailExists socket listener

Browse Source
This commit is contained in:
Julian Lam
2021-06-14 16:34:16 -04:00
parent 04b1f702cd
commit 12b2a979a0
3 changed files with 2 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
public/src/client/register.js
View File

@@ -131,22 +131,8 @@ define('forum/register', [
return callback(); return callback();
} }
socket.emit('user.emailExists', { showSuccess(email_notify, successIcon);
email: email, callback();
}, function (err, exists) {
if (err) {
app.alertError(err.message);
return callback();
}
if (exists) {
showError(email_notify, '[[error:email-taken]]');
} else {
showSuccess(email_notify, successIcon);
}
callback();
});
} }
function validateUsername(username, callback) { function validateUsername(username, callback) {

7
src/socket.io/user.js
View File

@@ -43,13 +43,6 @@ SocketUser.deleteAccount = async function (socket, data) {
await api.users.deleteAccount(socket, data); await api.users.deleteAccount(socket, data);
}; };
SocketUser.emailExists = async function (socket, data) {
if (!data || !data.email) {
throw new Error('[[error:invalid-data]]');
}
return await user.email.exists(data.email);
};
SocketUser.emailConfirm = async function (socket) { SocketUser.emailConfirm = async function (socket) {
if (!socket.uid) { if (!socket.uid) {
throw new Error('[[error:no-privileges]]'); throw new Error('[[error:no-privileges]]');

23
test/user.js
View File

@@ -1766,29 +1766,6 @@ describe('User', () => {
meta.config.allowAccountDeletion = oldValue; meta.config.allowAccountDeletion = oldValue;
}); });
it('should fail if data is invalid', (done) => {
socketUser.emailExists({ uid: testUid }, null, (err) => {
assert.equal(err.message, '[[error:invalid-data]]');
done();
});
});
it('should return true if email exists', (done) => {
socketUser.emailExists({ uid: testUid }, { email: 'john@example.com' }, (err, exists) => {
assert.ifError(err);
assert(exists);
done();
});
});
it('should return false if email does not exist', (done) => {
socketUser.emailExists({ uid: testUid }, { email: 'does@not.exist' }, (err, exists) => {
assert.ifError(err);
assert(!exists);
done();
});
});
it('should error if requireEmailConfirmation is disabled', (done) => { it('should error if requireEmailConfirmation is disabled', (done) => {
socketUser.emailConfirm({ uid: testUid }, {}, (err) => { socketUser.emailConfirm({ uid: testUid }, {}, (err) => {
assert.equal(err.message, '[[error:email-confirmations-are-disabled]]'); assert.equal(err.message, '[[error:email-confirmations-are-disabled]]');