Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: issue where the last flag filter could not be removed

Browse Source
This commit is contained in:
Julian Lam
2020-09-23 10:24:06 -04:00
parent abe8377387
commit 0fffe28941
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
public/src/client/flags/list.js
View File

@@ -38,9 +38,7 @@ define('forum/flags/list', ['components', 'Chart'], function (components, Chart)
filtersEl.find('[name="sort"]').val(ajaxify.data.sort);
document.getElementById('apply-filters').addEventListener('click', function () {
var payload = filtersEl.serializeArray().filter(function (item) {
return !!item.value;
});
var payload = filtersEl.serializeArray();
ajaxify.go('flags?' + (payload.length ? $.param(payload) : 'reset=1'));
});
};

6
src/controllers/mods.js
View File

@@ -47,7 +47,11 @@ modsController.flags.list = async function (req, res, next) {
// Parse query string params for filters, eliminate non-valid filters
filters = filters.reduce(function (memo, cur) {
if (req.query.hasOwnProperty(cur)) {
memo[cur] = req.query[cur];
if (req.query[cur] === '') {
delete req.session.flags_filters[cur];
} else {
memo[cur] = req.query[cur];
}
}
return memo;