Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-01 21:30:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #9085, dont prevent admins from deleting other users

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-12-09 10:15:30 -05:00
parent ff2aa17bbc
commit 0f480be658
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
public/language/en-GB/error.json
View File

@@ -107,6 +107,7 @@
"cant-ban-other-admins": "You can't ban other admins!",
"cant-remove-last-admin": "You are the only administrator. Add another user as an administrator before removing yourself as admin",
"account-deletion-disabled": "Account deletion is disabled",
"cant-delete-admin": "Remove administrator privileges from this account before attempting to delete it.",
"already-deleting": "Already deleting",

4
src/api/users.js
View File

@@ -250,8 +250,8 @@ async function processDeletion({ uid, method, password, caller }) {
const isSelf = parseInt(uid, 10) === caller.uid;
const isAdmin = await user.isAdministrator(caller.uid);
if (meta.config.allowAccountDelete !== 1) {
throw new Error('[[error:no-privileges]]');
if (isSelf && meta.config.allowAccountDelete !== 1) {
throw new Error('[[error:account-deletion-disabled]]');
} else if (!isSelf && !isAdmin) {
throw new Error('[[error:no-privileges]]');
} else if (isTargetAdmin) {