Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: make code climate happier?

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-06-24 16:10:06 -04:00
parent c718b7293e
commit 0d112b3605
1 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/categories/data.js
View File

@@ -56,25 +56,23 @@ module.exports = function (Categories) {
}; };
}; };
function defaultMinMaxTags(category, fields, fieldName, defaultField) {
if (!fields.length || fields.includes(fieldName)) {
const useDefault = !category.hasOwnProperty(fieldName) ||
category[fieldName] === null ||
category[fieldName] === '' ||
!parseInt(category[fieldName], 10);
category[fieldName] = useDefault ? meta.config[defaultField] : category[fieldName];
}
}
function modifyCategory(category, fields) { function modifyCategory(category, fields) {
if (!category) { if (!category) {
return; return;
} }
if (!fields.length || fields.includes('minTags')) { defaultMinMaxTags(category, fields, 'minTags', 'minimumTagsPerTopic');
const useDefault = !category.hasOwnProperty('minTags') || defaultMinMaxTags(category, fields, 'maxTags', 'maximumTagsPerTopic');
category.minTags === null ||
category.minTags === '' ||
!parseInt(category.minTags, 10);
category.minTags = useDefault ? meta.config.minimumTagsPerTopic : category.minTags;
}
if (!fields.length || fields.includes('maxTags')) {
const useDefault = !category.hasOwnProperty('maxTags') ||
category.maxTags === null ||
category.maxTags === '' ||
!parseInt(category.maxTags, 10);
category.maxTags = useDefault ? meta.config.maximumTagsPerTopic : category.maxTags;
}
db.parseIntFields(category, intFields, fields); db.parseIntFields(category, intFields, fields);